Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-04 21:18:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1239288 - Fix a race in the win32 job scheduler's shutdown. r=jrmuizel

Browse Source
This commit is contained in:
Nicolas Silva 2016-01-19 09:48:51 +01:00
parent 42b3ccc897
commit 59f28c22d9
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gfx/2d/JobScheduler_win32.cpp
View File

@ -132,9 +132,14 @@ MultiThreadedJobQueue::RegisterThread()
void void
MultiThreadedJobQueue::UnregisterThread() MultiThreadedJobQueue::UnregisterThread()
{ {
CriticalSectionAutoEnter lock(&mSection); mSection.Enter();
mThreadsCount -= 1; mThreadsCount -= 1;
if (mThreadsCount == 0) { bool finishShutdown = mThreadsCount == 0;
mSection.Leave();
if (finishShutdown) {
// Can't touch mSection or any other member from now on because this object
// may get deleted on the main thread after mShutdownEvent is set.
::SetEvent(mShutdownEvent); ::SetEvent(mShutdownEvent);
} }
} }