diff --git a/build/clang-plugin/mozsearch-plugin/MozsearchIndexer.cpp b/build/clang-plugin/mozsearch-plugin/MozsearchIndexer.cpp index c1fec0df189c..2af05ed04328 100644 --- a/build/clang-plugin/mozsearch-plugin/MozsearchIndexer.cpp +++ b/build/clang-plugin/mozsearch-plugin/MozsearchIndexer.cpp @@ -459,7 +459,9 @@ public: size_t Length = 0; for (std::string &Line : Nodupes) { Length += Line.length(); - fwrite(Line.c_str(), Line.length(), 1, Fp); + if (fwrite(Line.c_str(), Line.length(), 1, Fp) != 1) { + fprintf(stderr, "Unable to write to output file %s\n", Filename.c_str()); + } } fclose(Fp); diff --git a/dom/base/nsContentUtils.cpp b/dom/base/nsContentUtils.cpp index 2cd82215ec0a..641ecb33c946 100644 --- a/dom/base/nsContentUtils.cpp +++ b/dom/base/nsContentUtils.cpp @@ -1542,28 +1542,6 @@ nsContentUtils::IsJavaScriptLanguage(const nsString& aName) aName.LowerCaseEqualsLiteral("javascript1.5"); } -JSVersion -nsContentUtils::ParseJavascriptVersion(const nsAString& aVersionStr) -{ - if (aVersionStr.Length() != 3 || aVersionStr[0] != '1' || - aVersionStr[1] != '.') { - return JSVERSION_UNKNOWN; - } - - switch (aVersionStr[2]) { - case '0': /* fall through */ - case '1': /* fall through */ - case '2': /* fall through */ - case '3': /* fall through */ - case '4': /* fall through */ - case '5': return JSVERSION_DEFAULT; - case '6': return JSVERSION_1_6; - case '7': return JSVERSION_1_7; - case '8': return JSVERSION_1_8; - default: return JSVERSION_UNKNOWN; - } -} - void nsContentUtils::SplitMimeType(const nsAString& aValue, nsString& aType, nsString& aParams) diff --git a/dom/base/nsContentUtils.h b/dom/base/nsContentUtils.h index abf2e68da00c..b401488267f8 100644 --- a/dom/base/nsContentUtils.h +++ b/dom/base/nsContentUtils.h @@ -2633,12 +2633,6 @@ public: */ static bool IsJavaScriptLanguage(const nsString& aName); - /** - * Returns the JSVersion for a string of the form '1.n', n = 0, ..., 8, and - * JSVERSION_UNKNOWN for other strings. - */ - static JSVersion ParseJavascriptVersion(const nsAString& aVersionStr); - static bool IsJavascriptMIMEType(const nsAString& aMIMEType); static void SplitMimeType(const nsAString& aValue, nsString& aType, diff --git a/dom/script/ModuleLoadRequest.cpp b/dom/script/ModuleLoadRequest.cpp index c9b02b3f1126..af85028c4db7 100644 --- a/dom/script/ModuleLoadRequest.cpp +++ b/dom/script/ModuleLoadRequest.cpp @@ -29,13 +29,13 @@ NS_IMPL_ADDREF_INHERITED(ModuleLoadRequest, ScriptLoadRequest) NS_IMPL_RELEASE_INHERITED(ModuleLoadRequest, ScriptLoadRequest) ModuleLoadRequest::ModuleLoadRequest(nsIScriptElement* aElement, - uint32_t aVersion, + ValidJSVersion aValidJSVersion, CORSMode aCORSMode, const SRIMetadata& aIntegrity, ScriptLoader* aLoader) : ScriptLoadRequest(ScriptKind::Module, aElement, - aVersion, + aValidJSVersion, aCORSMode, aIntegrity), mIsTopLevel(true), diff --git a/dom/script/ModuleLoadRequest.h b/dom/script/ModuleLoadRequest.h index fff8a35e030b..01619d391346 100644 --- a/dom/script/ModuleLoadRequest.h +++ b/dom/script/ModuleLoadRequest.h @@ -32,7 +32,7 @@ public: NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(ModuleLoadRequest, ScriptLoadRequest) ModuleLoadRequest(nsIScriptElement* aElement, - uint32_t aVersion, + ValidJSVersion aValidJSVersion, CORSMode aCORSMode, const SRIMetadata& aIntegrity, ScriptLoader* aLoader); diff --git a/dom/script/ScriptLoadRequest.cpp b/dom/script/ScriptLoadRequest.cpp index 4875ba787543..fb5068ce6d66 100644 --- a/dom/script/ScriptLoadRequest.cpp +++ b/dom/script/ScriptLoadRequest.cpp @@ -40,7 +40,7 @@ NS_IMPL_CYCLE_COLLECTION_TRACE_END ScriptLoadRequest::ScriptLoadRequest(ScriptKind aKind, nsIScriptElement* aElement, - uint32_t aVersion, + ValidJSVersion aValidJSVersion, mozilla::CORSMode aCORSMode, const mozilla::dom::SRIMetadata& aIntegrity) : mKind(aKind) @@ -63,7 +63,7 @@ ScriptLoadRequest::ScriptLoadRequest(ScriptKind aKind, , mScriptText() , mScriptBytecode() , mBytecodeOffset(0) - , mJSVersion(aVersion) + , mValidJSVersion(aValidJSVersion) , mLineNo(1) , mCORSMode(aCORSMode) , mIntegrity(aIntegrity) diff --git a/dom/script/ScriptLoadRequest.h b/dom/script/ScriptLoadRequest.h index 62ab177d51f9..41245d956e54 100644 --- a/dom/script/ScriptLoadRequest.h +++ b/dom/script/ScriptLoadRequest.h @@ -29,6 +29,11 @@ enum class ScriptKind { Module }; +enum class ValidJSVersion : bool { + Invalid, + Valid +}; + /* * A class that handles loading and evaluation of