Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 20:35:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

do not raise an exception when revision is missing, this happens when file is deleted from CVS. checkin for bhearsum, r=rhelmer, b=370238

Browse Source
This commit is contained in:
rhelmer%mozilla.com 2007-02-13 02:47:30 +00:00
parent 3f63f6934d
commit 5ad5f81b31
2 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/buildbot/buildbot/changes/bonsaipoller.py
View File

@ -175,12 +175,7 @@ class BonsaiParser:
return filename
def _getRevision(self):
"""Returns the revision of the current <f> node"""
rev = self.currentFileNode.getAttribute("rev")
if rev == "":
raise InvalidResultError("A revision was missing from a file")
return rev
return self.currentFileNode.getAttribute("rev")
class BonsaiPoller(base.ChangeSource):
@ -215,7 +210,8 @@ class BonsaiPoller(base.ChangeSource):
@param cvsroot: The cvsroot of the repository. Usually this is
'/cvsroot'
@type pollInterval: int
@param pollInterval: The time (in seconds) between queries for changes
@param pollInterval: The time (in seconds) between queries for
changes
"""
self.bonsaiURL = bonsaiURL

10
tools/buildbot/buildbot/test/test_bonsaipoller.py
View File

@ -74,9 +74,6 @@ badUnparsedResult = badUnparsedResult.replace("</queryResults>", "")
invalidDateResult = deepcopy(goodUnparsedResult)
invalidDateResult = invalidDateResult.replace(str(date1), "foobar")
missingRevisionResult = deepcopy(goodUnparsedResult)
missingRevisionResult = missingRevisionResult.replace("rev=\""+rev3+"\"", "")
missingFilenameResult = deepcopy(goodUnparsedResult)
missingFilenameResult = missingFilenameResult.replace(file2, "")
@ -138,13 +135,6 @@ class TestBonsaiPoller(unittest.TestCase):
except InvalidResultError:
pass
def testMissingRevisionResult(self):
try:
BonsaiParser(StringIO(missingRevisionResult))
self.fail(badResultMsgs["missingRevisionResult"])
except InvalidResultError:
pass
def testMissingFilenameResult(self):
try:
BonsaiParser(StringIO(missingFilenameResult))