Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 02:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1522092: Disable PanelMultiView's keyboard navigation code for the Site Identity panel. r=johannh

Browse Source 
PanelMultiView's keyboard navigation code currently overrides the arrow keys in menulists.
This breaks the permission selectors in the Site Identity panel.
For now, just disable this keyboard navigation code.
DOM will then handle tabbing as it normally would.
This panel is more like a dialog than a menu, so users will generally navigate it with the tab key rather than the arrow keys anyway.
Note that the code in PanelMultiView which makes controls focusable still runs even with disablekeynav set, which is what we want.

Differential Revision: https://phabricator.services.mozilla.com/D21484

--HG--
extra : moz-landing-system : lando
This commit is contained in:
James Teh 2019-02-28 08:32:19 +00:00
parent 8b5599fc98
commit 5bbfcdf874
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
browser/components/controlcenter/content/panel.inc.xul
View File

@ -13,7 +13,8 @@
orient="vertical">
<panelmultiview id="identity-popup-multiView"
mainViewId="identity-popup-mainView">
mainViewId="identity-popup-mainView"
disablekeynav="true">
<panelview id="identity-popup-mainView"
descriptionheightworkaround="true">
<vbox id="identity-popup-mainView-panel-header">