Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1675789 - Do not used flipped characters for bidi pseudo-locale; r=zbraniecki

Browse Source 
This switches to using accented characters without elongation for the bidi
pseudo-locale to improve readability. We received feedback that the
flipped characters were too difficult to read.

This also updates the test expectations.

Differential Revision: https://phabricator.services.mozilla.com/D96855
This commit is contained in:
Dan Minor 2020-11-13 13:23:12 +00:00
parent bc574a5dfa
commit 5bc2b7d62a
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
intl/l10n/rust/fluent-ffi/src/bundle.rs
View File

@ -28,7 +28,7 @@ fn transform_accented(s: &str) -> Cow<str> {
}
fn transform_bidi(s: &str) -> Cow<str> {
transform_dom(s, true, false)
transform_dom(s, false, false)
}
fn format_numbers(num: &FluentValue, intls: &IntlLangMemoizer) -> Option<String> {

8
intl/l10n/test/test_pseudo.js
View File

@ -69,9 +69,9 @@ add_task(async function test_accented_works() {
Services.prefs.setStringPref("intl.l10n.pseudo", "accented");
let message = (await l10n.formatMessages([{id: "key"}]))[0];
ok(message.value.includes("Ŧħīş īş ȧȧ şīƞɠŀḗḗ ḿḗḗşşȧȧɠḗḗ"));
ok(message.value.includes("Ŧħiş iş aa şiƞɠŀee ḿeeşşaaɠee"));
let attr0 = getAttributeByName(message.attributes, "tooltip");
ok(attr0.value.includes("Ŧħīş īş ȧȧ ŧǿǿǿǿŀŧīƥ"));
ok(attr0.value.includes("Ŧħiş iş aa ŧooooŀŧiƥ"));
let attr1 = getAttributeByName(message.attributes, "accesskey");
equal(attr1.value, "f");
}
@ -82,9 +82,9 @@ add_task(async function test_accented_works() {
Services.prefs.setStringPref("intl.l10n.pseudo", "bidi");
let message = (await l10n.formatMessages([{id: "key"}]))[0];
ok(message.value.includes("ıs ɐ sıuƃʅǝ ɯǝssɐƃǝ"));
ok(message.value.includes("iş a şiƞɠŀe ḿeşşaɠe"));
let attr0 = getAttributeByName(message.attributes, "tooltip");
ok(attr0.value.includes("⊥ɥıs ıs ɐ ʇooʅʇıd"));
ok(attr0.value.includes("Ŧħiş iş a ŧooŀŧiƥ"));
let attr1 = getAttributeByName(message.attributes, "accesskey");
equal(attr1.value, "f");
}