Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-21 09:49:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 287383 heap corruption from ReplaceChar/StripChars

Browse Source 
r=darin sr=darin
This commit is contained in:
timeless%mozdev.org 2005-03-24 18:42:56 +00:00
parent 10291e93a2
commit 5bde169b94
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
embedding/tests/mfcembed/BrowserView.cpp
View File

@ -88,13 +88,14 @@ ReplaceChar(nsAString &str, char oldChar, char newChar)
// XXX this could be much more efficient
PRUnichar *data = NS_StringCloneData(str);
PRUnichar *datastring = data;
for (; *data; ++data)
{
if ((char ) *data == oldChar)
*data = (PRUnichar) newChar;
}
NS_StringSetData(str, data);
nsMemory::Free(data);
NS_StringSetData(str, datastring);
nsMemory::Free(datastring);
}
static void
@ -105,6 +106,7 @@ StripChars(nsAString &str, const char *chars)
PRUint32 len = str.Length();
PRUnichar *data = NS_StringCloneData(str);
PRUnichar *datastring = data;
PRUnichar *dataEnd = data + len;
for (; *data; ++data)
{
@ -115,8 +117,8 @@ StripChars(nsAString &str, const char *chars)
--dataEnd;
}
}
NS_StringSetData(str, data);
nsMemory::Free(data);
NS_StringSetData(str, datastring);
nsMemory::Free(datastring);
}
static void
@ -127,6 +129,7 @@ StripChars(nsACString &str, const char *chars)
PRUint32 len = str.Length();
char *data = NS_CStringCloneData(str);
char *datastring = data;
char *dataEnd = data + len;
for (; *data; ++data)
{
@ -137,8 +140,8 @@ StripChars(nsACString &str, const char *chars)
--dataEnd;
}
}
NS_CStringSetData(str, data);
nsMemory::Free(data);
NS_CStringSetData(str, datastring);
nsMemory::Free(datastring);
}
static const char* kWhitespace="\b\t\r\n ";