Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1290214 - Make ServoRestyleManager::AttributeChanged a no-op. r=emilio

Browse Source 
We do all the work we need to do with the snapshot model in AttributeWillChange.
This commit is contained in:
Bobby Holley 2016-07-28 13:14:02 -07:00
parent 7c2695a9d0
commit 5cc53812ef
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
layout/base/ServoRestyleManager.cpp
View File

@ -296,14 +296,6 @@ ServoRestyleManager::AttributeWillChange(Element* aElement,
snapshot->AddAttrs(aElement);
}
void
ServoRestyleManager::AttributeChanged(Element* aElement, int32_t aNameSpaceID,
nsIAtom* aAttribute, int32_t aModType,
const nsAttrValue* aOldValue)
{
NS_ERROR("stylo: ServoRestyleManager::AttributeChanged not implemented");
}
nsresult
ServoRestyleManager::ReparentStyleContext(nsIFrame* aFrame)
{

5
layout/base/ServoRestyleManager.h
View File

@ -62,9 +62,12 @@ public:
nsIAtom* aAttribute,
int32_t aModType,
const nsAttrValue* aNewValue);
// XXXbholley: We should assert that the element is already snapshotted.
void AttributeChanged(dom::Element* aElement, int32_t aNameSpaceID,
nsIAtom* aAttribute, int32_t aModType,
const nsAttrValue* aOldValue);
const nsAttrValue* aOldValue) {}
nsresult ReparentStyleContext(nsIFrame* aFrame);
bool HasPendingRestyles() { return !mModifiedElements.IsEmpty(); }