Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 00:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1062379 - Don't reduce Gecko thread priority for multicore devices; r=mfinkle

Browse Source 
For multicore devices, the Gecko thread should be able to run on a separate core than the UI thread, so there's no reason to lower the Gecko thread priority in consideration for the UI thread. Patch also fixes some race conditions involving sGeckoThread in ThreadUtils.
This commit is contained in:
Jim Chen 2014-09-09 13:46:48 -04:00
parent 43dc4cf665
commit 5cdb401e29
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mobile/android/base/util/ThreadUtils.java
View File

@ -36,7 +36,7 @@ public final class ThreadUtils {
// this out at compile time.
public static Handler sGeckoHandler;
public static MessageQueue sGeckoQueue;
public static Thread sGeckoThread;
public static volatile Thread sGeckoThread;
// Delayed Runnable that resets the Gecko thread priority.
private static final Runnable sPriorityResetRunnable = new Runnable() {
@ -130,6 +130,10 @@ public final class ThreadUtils {
}
public static void assertNotOnGeckoThread() {
if (sGeckoThread == null) {
// Cannot be on Gecko thread if Gecko thread is not live yet.
return;
}
assertNotOnThread(sGeckoThread, AssertBehavior.THROW);
}
@ -204,7 +208,13 @@ public final class ThreadUtils {
* @param timeout Timeout in ms after which the priority will be reset
*/
public static void reduceGeckoPriority(long timeout) {
if (!sIsGeckoPriorityReduced) {
if (Runtime.getRuntime().availableProcessors() > 1) {
// Don't reduce priority for multicore devices. We use availableProcessors()
// for its fast performance. It may give false negatives (i.e. multicore
// detected as single-core), but we can tolerate this behavior.
return;
}
if (!sIsGeckoPriorityReduced && sGeckoThread != null) {
sIsGeckoPriorityReduced = true;
sGeckoThread.setPriority(Thread.MIN_PRIORITY);
getUiHandler().postDelayed(sPriorityResetRunnable, timeout);