From 5ce571ea26b579110024dec8ad2c027420ec742a Mon Sep 17 00:00:00 2001
From: Justin Dolske <dolske@mozilla.com>
Date: Sun, 29 Mar 2009 15:29:21 -0700
Subject: [PATCH] Bug 484935 - videocontrols should use display:none on hidden
 items to minimize CPU usage. r=enn

---
 toolkit/content/widgets/videocontrols.css | 11 -----------
 toolkit/content/widgets/videocontrols.xml | 15 +++++----------
 2 files changed, 5 insertions(+), 21 deletions(-)

diff --git a/toolkit/content/widgets/videocontrols.css b/toolkit/content/widgets/videocontrols.css
index c7bbde78d83e..84805f527059 100644
--- a/toolkit/content/widgets/videocontrols.css
+++ b/toolkit/content/widgets/videocontrols.css
@@ -1,16 +1,5 @@
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
-/* Bug 449358: hide controlbar by default, so we don't show broken controls when script is disabled */
-.controlBar {
-     visibility: hidden;
-     opacity: 0.0;
-}
-
 .scrubber {
     -moz-binding: url("chrome://global/content/bindings/videocontrols.xml#suppressChangeEvent");
 }
-
-.statusOverlay {
-    visibility: hidden;
-    opacity: 0.0;
-}
diff --git a/toolkit/content/widgets/videocontrols.xml b/toolkit/content/widgets/videocontrols.xml
index ffd22a17d68a..2e7daf5f6dc9 100644
--- a/toolkit/content/widgets/videocontrols.xml
+++ b/toolkit/content/widgets/videocontrols.xml
@@ -52,13 +52,13 @@
 
     <xbl:content xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
         <stack flex="1">
-            <vbox class="statusOverlay">
+            <vbox class="statusOverlay" hidden="true">
                 <box class="statusIcon" flex="1"/>
             </vbox>
 
             <vbox>
                 <spacer flex="1"/>
-                <hbox class="controlBar">
+                <hbox class="controlBar" hidden="true">
                     <button class="playButton" oncommand="document.getBindingParent(this).Utils.togglePause();"/>
                     <stack class="scrubberStack" flex="1">
                         <box class="backgroundBar"/>
@@ -509,12 +509,8 @@
                     //self.log("Fading " + fader.name + " to opacity " + opacity);
 
                     fader.element.style.opacity = opacity;
-
-                    // Use .visibility to ignore mouse clicks when hidden.
-                    if (fader.isVisible)
-                        fader.element.style.visibility = "visible";
-                    else
-                        fader.element.style.visibility = "hidden";
+                    // Hide the element to ignore mouse clicks and reduce throbber CPU usage.
+                    fader.element.setAttribute("hidden", !fader.isVisible);
 
                     // Is the animation done?
                     if (pos == 1) {
@@ -596,8 +592,7 @@
             // (Note: the |controls| attribute is already handled via layout/style/html.css)
             if (!(video.autoplay && video.mozAutoplayEnabled) || !this.Utils.dynamicControls) {
                 var fader = this.Utils.controlFader;
-                fader.element.style.visibility = "visible";
-                fader.element.style.opacity = 1.0;
+                fader.element.setAttribute("hidden", "false");
                 fader.isVisible = true;
                 fader.fadingIn = true;
             }