Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 21:05:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug 311151: Attempt to restore some lost Tp from bug 311090 by adding a fast path that avoids xpconnect. r+sr=bzbarsky

Browse Source
This commit is contained in:
mrbkap%gmail.com 2005-10-06 19:58:26 +00:00
parent 306776aaca
commit 5d24c3db6d
1 changed files with 34 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
dom/src/base/nsDOMClassInfo.cpp
View File

@ -6698,21 +6698,43 @@ nsGenericArraySH::NewResolve(nsIXPConnectWrappedNative *wrapper, JSContext *cx,
PRInt32 n = GetArrayIndexFromId(cx, id, &is_number);
if (is_number && n >= 0) {
PRInt32 length = 0;
jsval lenval;
// XXX The following is a cheap optimization to avoid hitting xpconnect to
// get the length. We may want to consider asking our concrete
// implementation for the length, and falling back onto the GetProperty if
// it doesn't provide one.
if (!JS_GetProperty(cx, obj, "length", &lenval)) {
return NS_ERROR_UNEXPECTED;
PRUint32 length;
nsCOMPtr<nsIDOMNodeList> map = do_QueryWrappedNative(wrapper);
if (map) {
// Fast path: Get the length from our map.
map->GetLength(&length);
} else {
// Slow path: We don't know how to get the length in a fast way, ask our
// implementation.
jsval lenval;
if (!JS_GetProperty(cx, obj, "length", &lenval)) {
return NS_ERROR_UNEXPECTED;
}
if (!JSVAL_IS_INT(lenval)) {
// This can apparently happen with some sparse array impls falling back
// onto this code.
return NS_OK;
}
PRInt32 slen = JSVAL_TO_INT(lenval);
if (slen < 0) {
return NS_OK;
}
length = (PRUint32)slen;
}
if (!JSVAL_IS_INT(lenval)) {
// This can apparently happen with some sparse array impls falling back
// onto this code.
return NS_OK;
}
length = JSVAL_TO_INT(lenval);
if (n < length) {
if ((PRUint32)n < length) {
*_retval = ::JS_DefineElement(cx, obj, n, JSVAL_VOID, nsnull, nsnull,
JSPROP_ENUMERATE);
*objp = obj;