Backed out changeset a3400287932b (bug 1634051) for perma failures on browser_favicon_firstParty.js. CLOSED TREE

browser/base/content/browser-allTabsMenu.inc.xhtml

@@ -2,44 +2,53 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
-<html:template id="allTabsMenu-container">
-  <panelview id="allTabsMenu-allTabsView" class="PanelUI-subView">
-    <vbox class="panel-subview-body">
-      <toolbarbutton id="allTabsMenu-undoCloseTab"
-                     class="subviewbutton subviewbutton-iconic"
-                     data-l10n-id="all-tabs-menu-undo-close-tab"
-                     key="key_undoCloseTab"
-                     command="History:UndoCloseTab"/>
-      <toolbarbutton id="allTabsMenu-searchTabs"
-                     class="subviewbutton subviewbutton-iconic"
-                     oncommand="gTabsPanel.searchTabs();"
-                     data-l10n-id="all-tabs-menu-search-tabs"/>
-      <toolbarbutton id="allTabsMenu-containerTabsButton"
-                     class="subviewbutton subviewbutton-nav"
-                     closemenu="none"
-                     oncommand="PanelUI.showSubView('allTabsMenu-containerTabsView', this);"
-                     data-l10n-id="all-tabs-menu-new-user-context"/>
-      <toolbarseparator id="allTabsMenu-hiddenTabsSeparator"/>
-      <toolbarbutton id="allTabsMenu-hiddenTabsButton"
-                     class="subviewbutton subviewbutton-nav"
-                     closemenu="none"
-                     oncommand="PanelUI.showSubView('allTabsMenu-hiddenTabsView', this);"
-                     data-l10n-id="all-tabs-menu-hidden-tabs"/>
-      <toolbarseparator id="allTabsMenu-tabsSeparator"/>
-      <vbox id="allTabsMenu-allTabsViewTabs" class="panel-subview-body"/>
-    </vbox>
-  </panelview>
+<panel id="allTabsMenu"
+       class="cui-widget-panel"
+       role="group"
+       type="arrow"
+       hidden="true"
+       flip="slide"
+       position="bottomcenter topright"
+       noautofocus="true">
+  <panelmultiview mainViewId="allTabsMenu-allTabsView" disablekeynav="true">
+    <panelview id="allTabsMenu-allTabsView" class="PanelUI-subView">
+      <vbox class="panel-subview-body">
+        <toolbarbutton id="allTabsMenu-undoCloseTab"
+                       class="subviewbutton subviewbutton-iconic"
+                       data-l10n-id="all-tabs-menu-undo-close-tab"
+                       key="key_undoCloseTab"
+                       command="History:UndoCloseTab"/>
+        <toolbarbutton id="allTabsMenu-searchTabs"
+                       class="subviewbutton subviewbutton-iconic"
+                       oncommand="gTabsPanel.searchTabs();"
+                       data-l10n-id="all-tabs-menu-search-tabs"/>
+        <toolbarbutton id="allTabsMenu-containerTabsButton"
+                       class="subviewbutton subviewbutton-nav"
+                       closemenu="none"
+                       oncommand="PanelUI.showSubView('allTabsMenu-containerTabsView', this);"
+                       data-l10n-id="all-tabs-menu-new-user-context"/>
+        <toolbarseparator id="allTabsMenu-hiddenTabsSeparator"/>
+        <toolbarbutton id="allTabsMenu-hiddenTabsButton"
+                       class="subviewbutton subviewbutton-nav"
+                       closemenu="none"
+                       oncommand="PanelUI.showSubView('allTabsMenu-hiddenTabsView', this);"
+                       data-l10n-id="all-tabs-menu-hidden-tabs"/>
+        <toolbarseparator id="allTabsMenu-tabsSeparator"/>
+        <vbox id="allTabsMenu-allTabsViewTabs" class="panel-subview-body"/>
+      </vbox>
+    </panelview>
 
-  <panelview id="allTabsMenu-hiddenTabsView" class="PanelUI-subView">
-    <vbox class="panel-subview-body"/>
-  </panelview>
+    <panelview id="allTabsMenu-hiddenTabsView" class="PanelUI-subView">
+      <vbox class="panel-subview-body"/>
+    </panelview>
 
-  <panelview id="allTabsMenu-containerTabsView" class="PanelUI-subView">
-    <vbox class="panel-subview-body">
-      <toolbarseparator class="container-tabs-submenu-separator"/>
-      <toolbarbutton class="subviewbutton"
-                     data-l10n-id="all-tabs-menu-manage-user-context"
-                     command="Browser:OpenAboutContainers"/>
-    </vbox>
-  </panelview>
-</html:template>
+    <panelview id="allTabsMenu-containerTabsView" class="PanelUI-subView">
+      <vbox class="panel-subview-body">
+        <toolbarseparator class="container-tabs-submenu-separator"/>
+        <toolbarbutton class="subviewbutton"
+                       data-l10n-id="all-tabs-menu-manage-user-context"
+                       command="Browser:OpenAboutContainers"/>
+      </vbox>
+    </panelview>
+  </panelmultiview>
+</panel>

browser/base/content/browser-allTabsMenu.js

@@ -27,8 +27,6 @@ var gTabsPanel = {
     if (this._initializedElements) {
       return;
     }
-    let template = document.getElementById("allTabsMenu-container");
-    template.replaceWith(template.content);
 
     for (let [name, id] of Object.entries(this.kElements)) {
       this[name] = document.getElementById(id);
@@ -149,9 +147,8 @@ var gTabsPanel = {
   },
 
   hideAllTabsPanel() {
-    if (this.allTabsView) {
-      PanelMultiView.hidePopup(this.allTabsView.closest("panel"));
-    }
+    this.init();
+    PanelMultiView.hidePopup(this.allTabsView.closest("panel"));
   },
 
   showHiddenTabsPanel(event) {

browser/base/content/browser.js

@@ -2270,6 +2270,11 @@ var gBrowserInit = {
       gSync.init();
     });
 
+    scheduleIdleTask(() => {
+      // Initialize the all tabs menu
+      gTabsPanel.init();
+    });
+
     scheduleIdleTask(() => {
       // Read prefers-reduced-motion setting
       let reduceMotionQuery = window.matchMedia(