Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 23:31:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1449042: Negotiate tracks even when they're not active. r=drno

Browse Source 
MozReview-Commit-ID: CBhwHgjt1gf

--HG--
extra : rebase_source : c38a52290154e6d800a9f34f1ce87eab8859afa5
extra : source : cd4a5a800efa075bc1c4ba0c672bd301ee694ec0
This commit is contained in:
Byron Campen [:bwc] 2018-03-27 13:39:10 -05:00
parent fd746e9933
commit 5d6b88c22d
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
View File

@ -1095,25 +1095,21 @@ JsepSessionImpl::MakeNegotiatedTransceiver(const SdpMediaSection& remote,
}
transceiver->mSendTrack.SetActive(sending);
if (sending) {
transceiver->mSendTrack.Negotiate(answer, remote);
}
transceiver->mSendTrack.Negotiate(answer, remote);
JsepTrack& recvTrack = transceiver->mRecvTrack;
recvTrack.SetActive(receiving);
if (receiving) {
recvTrack.Negotiate(answer, remote);
recvTrack.Negotiate(answer, remote);
if (transceiver->HasBundleLevel() &&
recvTrack.GetSsrcs().empty() &&
recvTrack.GetMediaType() != SdpMediaSection::kApplication) {
// TODO(bug 1105005): Once we have urn:ietf:params:rtp-hdrext:sdes:mid
// support, we should only fire this warning if that extension was not
// negotiated.
MOZ_MTLOG(ML_ERROR, "[" << mName << "]: Bundled m-section has no ssrc "
"attributes. This may cause media packets to be "
"dropped.");
}
if (transceiver->HasBundleLevel() &&
recvTrack.GetSsrcs().empty() &&
recvTrack.GetMediaType() != SdpMediaSection::kApplication) {
// TODO(bug 1105005): Once we have urn:ietf:params:rtp-hdrext:sdes:mid
// support, we should only fire this warning if that extension was not
// negotiated.
MOZ_MTLOG(ML_ERROR, "[" << mName << "]: Bundled m-section has no ssrc "
"attributes. This may cause media packets to be "
"dropped.");
}
if (transceiver->mTransport->mComponents == 2) {