Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-30 05:35:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1339535 - Set the hadElementsAccess flag less eagerly to avoid unnecessary Shape changes. r=evilpie

Browse Source
This commit is contained in:
Jan de Mooij 2017-02-27 18:56:58 +01:00
parent d80b2440cc
commit 5e3013cebd
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
js/src/vm/Interpreter.cpp
View File

@ -1500,8 +1500,19 @@ SetObjectElementOperation(JSContext* cx, HandleObject obj, HandleId id, HandleVa
} }
} }
if (obj->isNative() && !JSID_IS_INT(id) && !JSObject::setHadElementsAccess(cx, obj)) // Set the HadElementsAccess flag on the object if needed. This flag is
return false; // used to do more eager dictionary-mode conversion for objects that are
// used as hashmaps. Set this flag only for objects with many properties,
// to avoid unnecessary Shape changes.
if (obj->isNative() &&
JSID_IS_ATOM(id) &&
!obj->as<NativeObject>().inDictionaryMode() &&
!obj->hadElementsAccess() &&
obj->as<NativeObject>().slotSpan() > PropertyTree::MAX_HEIGHT_WITH_ELEMENTS_ACCESS / 3)
{
if (!JSObject::setHadElementsAccess(cx, obj))
return false;
}
ObjectOpResult result; ObjectOpResult result;
return SetProperty(cx, obj, id, value, receiver, result) && return SetProperty(cx, obj, id, value, receiver, result) &&