Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 23:35:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 599482: need to call the "removed" handler when popup notifications are removed due to location changes, r=dtownsend, a=blocking

Browse Source 
--HG--
extra : rebase_source : bc108537233f96bd353846829e3489c243257dd3
This commit is contained in:
Gavin Sharp 2010-09-24 17:04:04 -04:00
parent 3d4488f4c7
commit 5e812d788f
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
browser/base/content/test/browser_popupNotification.js
View File

@ -355,7 +355,7 @@ var tests = [
}, },
// The removal triggers another popuphidden event. // The removal triggers another popuphidden event.
function (popup) {} function (popup) {}
], ]
}, },
// Test optional params // Test optional params
{ // Test #10 { // Test #10
@ -414,7 +414,7 @@ var tests = [
loadURI("http://example.org/", function() { loadURI("http://example.org/", function() {
loadURI("http://example.com/", function() { loadURI("http://example.com/", function() {
// Next load will hide the notification // Next load will remove the notification
self.complete = true; self.complete = true;
loadURI("http://example.org/"); loadURI("http://example.org/");
@ -423,7 +423,7 @@ var tests = [
}, },
onHidden: function (popup) { onHidden: function (popup) {
ok(this.complete, "Should only have hidden the notification after 3 page loads"); ok(this.complete, "Should only have hidden the notification after 3 page loads");
this.notification.remove(); ok(this.notifyObj.removedCallbackTriggered, "removal callback triggered");
gBrowser.removeTab(gBrowser.selectedTab); gBrowser.removeTab(gBrowser.selectedTab);
gBrowser.selectedTab = this.oldSelectedTab; gBrowser.selectedTab = this.oldSelectedTab;
} }

1
toolkit/content/PopupNotifications.jsm
View File

@ -290,6 +290,7 @@ PopupNotifications.prototype = {
return true; return true;
} }
this._fireCallback(notification, "removed");
return false; return false;
}, this); }, this);