Bug 1503379 - Update 'New folder' button to match specification. r=dao

Differential Revision: https://phabricator.services.mozilla.com/D10310

--HG--
rename : browser/themes/shared/tabbrowser/newtab.svg => browser/themes/shared/icons/add.svg
extra : moz-landing-system : lando

browser/themes/osx/browser.css

@@ -428,21 +428,26 @@ html|input.urlbar-input {
   border: 1px solid var(--panel-separator-color);
   margin: 0;
   padding: 0;
-  height: 20px;
+  height: 24px;
 }
 
 #editBMPanel_newFolderButton {
   -moz-appearance: none;
-  border: 0 solid var(--panel-separator-color);
-  border-inline-end-width: 1px;
+  -moz-box-flex: 1;
+  -moz-context-properties: fill, fill-opacity;
+  fill: currentColor;
+  fill-opacity: 0.8;
+  border: none;
   padding: 0 9px;
   margin: 0;
-  min-width: 21px;
-  min-height: 20px;
-  height: 20px;
+  min-height: 24px;
+  height: 24px;
   color: inherit;
-  list-style-image: url("chrome://browser/skin/panel-plus-sign.png");
-  position: relative;
+  list-style-image: url("chrome://browser/skin/add.svg");
+}
+
+#editBMPanel_newFolderButton:hover {
+  background-color: var(--arrowpanel-dimmed);
 }
 
 #editBMPanel_newFolderButton:hover:active {
@@ -453,6 +458,11 @@ html|input.urlbar-input {
   box-shadow: var(--focus-ring-box-shadow);
 }
 
+#editBMPanel_newFolderButton .button-text {
+  -moz-box-flex: 1; /* push the button icon to the start side */
+  text-align: start;
+}
+
 #editBMPanel_folderMenuList {
   margin: 0;
   min-height: 22px;
@@ -538,11 +548,6 @@ html|input.urlbar-input {
   list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
 }
 
-#editBMPanel_tagsField > moz-input-box > html|*.textbox-input::placeholder {
-  opacity: 1.0;
-  color: #bbb;
-}
-
 /* ----- SIDEBAR ELEMENTS ----- */
 
 %include ../shared/sidebar.inc.css

browser/themes/osx/jar.mn

@@ -9,7 +9,6 @@ browser.jar:
 * skin/classic/browser/syncedtabs/sidebar.css          (syncedtabs/sidebar.css)
 * skin/classic/browser/browser.css
 * skin/classic/browser/compacttheme.css
-  skin/classic/browser/panel-plus-sign.png
 * skin/classic/browser/pageInfo.css
 * skin/classic/browser/searchbar.css
   skin/classic/browser/slowStartup-16.png

browser/themes/shared/jar.inc.mn

@@ -126,6 +126,7 @@
 
   skin/classic/browser/accessibility.svg              (../shared/icons/accessibility.svg)
   skin/classic/browser/accessibility-active.svg       (../shared/icons/accessibility-active.svg)
+  skin/classic/browser/add.svg                        (../shared/icons/add.svg)
   skin/classic/browser/arrow-left.svg                 (../shared/icons/arrow-left.svg)
   skin/classic/browser/back.svg                       (../shared/icons/back.svg)
   skin/classic/browser/back-12.svg                    (../shared/icons/back-12.svg)
@@ -202,7 +203,6 @@
   skin/classic/browser/tabbrowser/loading-30fps.svg            (../shared/tabbrowser/loading-30fps.svg)
   skin/classic/browser/tabbrowser/loading-burst.svg            (../shared/tabbrowser/loading-burst.svg)
   skin/classic/browser/tabbrowser/crashed.svg                  (../shared/tabbrowser/crashed.svg)
-  skin/classic/browser/tabbrowser/newtab.svg                   (../shared/tabbrowser/newtab.svg)
   skin/classic/browser/tabbrowser/indicator-tab-attention.svg  (../shared/tabbrowser/indicator-tab-attention.svg)
   skin/classic/browser/tabbrowser/pendingpaint.png             (../shared/tabbrowser/pendingpaint.png)
   skin/classic/browser/tabbrowser/tab-audio-playing.svg        (../shared/tabbrowser/tab-audio-playing.svg)

browser/themes/shared/tabs.inc.css

@@ -719,7 +719,7 @@
 .tabs-newtab-button,
 #TabsToolbar > #new-tab-button ,
 #TabsToolbar > toolbarpaletteitem > #new-tab-button {
-  list-style-image: url(chrome://browser/skin/tabbrowser/newtab.svg);
+  list-style-image: url(chrome://browser/skin/add.svg);
 }
 
 /* All tabs button and menupopup */