Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-04-01 12:03:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1606888 - remove signon.management.page.enabled r=Gijs

Browse Source 
Completely removes the signon.management.page.enabled pref.

Differential Revision: https://phabricator.services.mozilla.com/D58879

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Kristen Wright 2020-01-07 01:42:32 +00:00
parent 9226c571f4
commit 5fbcf93b87
8 changed files with 0 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
browser/app/profile/firefox.js
View File

@ -1733,7 +1733,6 @@ pref("extensions.pocket.enabled", true);
pref("extensions.pocket.oAuthConsumerKey", "40249-e88c401e1b1f2242d9e441c4");
pref("extensions.pocket.site", "getpocket.com");
pref("signon.management.page.enabled", true);
pref("signon.management.page.breach-alerts.enabled", true);
pref("signon.management.page.sort", "name");
pref("signon.management.overrideURI", "about:logins?filter=%DOMAIN%");

13
browser/components/about/AboutRedirector.cpp
View File

@ -21,8 +21,6 @@ namespace browser {
NS_IMPL_ISUPPORTS(AboutRedirector, nsIAboutModule)
bool AboutRedirector::sAboutLoginsEnabled = false;
static const uint32_t ACTIVITY_STREAM_FLAGS =
nsIAboutModule::ALLOW_SCRIPT | nsIAboutModule::ENABLE_INDEXED_DB |
nsIAboutModule::URI_MUST_LOAD_IN_CHILD |
@ -157,13 +155,6 @@ AboutRedirector::NewChannel(nsIURI* aURI, nsILoadInfo* aLoadInfo,
nsCOMPtr<nsIIOService> ioService = do_GetIOService(&rv);
NS_ENSURE_SUCCESS(rv, rv);
static bool sAboutLoginsCacheInited = false;
if (!sAboutLoginsCacheInited) {
Preferences::AddBoolVarCache(&AboutRedirector::sAboutLoginsEnabled,
"signon.management.page.enabled");
sAboutLoginsCacheInited = true;
}
for (auto& redir : kRedirMap) {
if (!strcmp(path.get(), redir.id)) {
nsAutoCString url;
@ -180,10 +171,6 @@ AboutRedirector::NewChannel(nsIURI* aURI, nsILoadInfo* aLoadInfo,
NS_ENSURE_SUCCESS(rv, rv);
}
if (!sAboutLoginsEnabled && path.EqualsLiteral("logins")) {
return NS_ERROR_NOT_AVAILABLE;
}
if (path.EqualsLiteral("welcome")) {
nsCOMPtr<nsIAboutNewTabService> aboutNewTabService =
do_GetService("@mozilla.org/browser/aboutnewtab-service;1", &rv);

3
browser/components/about/AboutRedirector.h
View File

@ -22,9 +22,6 @@ class AboutRedirector : public nsIAboutModule {
protected:
virtual ~AboutRedirector() {}
private:
static bool sAboutLoginsEnabled;
};
} // namespace browser

2
browser/components/aboutlogins/tests/browser/browser.ini
View File

@ -1,6 +1,4 @@
[DEFAULT]
prefs =
signon.management.page.enabled=true
support-files =
head.js

4
browser/components/contextualidentity/test/browser/browser_aboutURLs.js
View File

@ -5,10 +5,6 @@
requestLongerTimeout(2);
add_task(async function() {
await SpecialPowers.pushPrefEnv({
set: [["signon.management.page.enabled", true]],
});
let aboutURLs = [];
// List of about: URLs that may cause problem, so we skip them in this test.

2
browser/components/originattributes/test/browser/browser_firstPartyIsolation_aboutPages.js
View File

@ -4,11 +4,9 @@ if (Services.prefs.getBoolPref("fission.autostart")) {
add_task(async function setup() {
Services.prefs.setBoolPref("privacy.firstparty.isolate", true);
Services.prefs.setBoolPref("signon.management.page.enabled", true);
registerCleanupFunction(function() {
Services.prefs.clearUserPref("privacy.firstparty.isolate");
Services.prefs.clearUserPref("signon.management.page.enabled");
});
});

4
browser/components/preferences/in-content/tests/browser_password_management.js
View File

@ -98,10 +98,6 @@ add_task(async function subdialog_cleanup() {
});
add_task(async function test_openPasswordManagement_overrideURI() {
await SpecialPowers.pushPrefEnv({
set: [["signon.management.page.enabled", true]],
});
Services.prefs.setStringPref(
PREF_MANAGEMENT_URI,
"about:logins?filter=%DOMAIN%"

4
toolkit/components/passwordmgr/test/browser/browser_openPasswordManager.js
View File

@ -39,10 +39,6 @@ add_task(async function test_filter() {
});
add_task(async function test_management_overrideURI_noFilter() {
await SpecialPowers.pushPrefEnv({
set: [["signon.management.page.enabled", true]],
});
Services.prefs.setStringPref(
PREF_MANAGEMENT_URI,
"about:logins?filter=%DOMAIN%"