Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 08:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1253476 - Use in-class member initializers in Animation.h; r=hiro

Browse Source 
The in-class initializers are easier to maintain since you don't have to try and
match them up with the constructor initializer list (including matching the
order).

Differential Revision: https://phabricator.services.mozilla.com/D30317

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Brian Birtles 2019-05-20 05:20:07 +00:00
parent 94950fffc0
commit 5fe06d1f3c
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
dom/animation/Animation.h
View File

@ -51,15 +51,7 @@ class Animation : public DOMEventTargetHelper,
public:
explicit Animation(nsIGlobalObject* aGlobal)
: DOMEventTargetHelper(aGlobal),
mPlaybackRate(1.0),
mAnimationIndex(sNextAnimationIndex++),
mCachedChildIndex(-1),
mPendingState(PendingState::NotPending),
mFinishedAtLastComposeStyle(false),
mIsRelevant(false),
mFinishedIsResolved(false),
mSyncWithGeometricAnimations(false) {}
: DOMEventTargetHelper(aGlobal), mAnimationIndex(sNextAnimationIndex++) {}
NS_DECL_ISUPPORTS_INHERITED
NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(Animation, DOMEventTargetHelper)
@ -527,7 +519,7 @@ class Animation : public DOMEventTargetHelper,
Nullable<TimeDuration> mHoldTime; // Animation timescale
Nullable<TimeDuration> mPendingReadyTime; // Timeline timescale
Nullable<TimeDuration> mPreviousCurrentTime; // Animation timescale
double mPlaybackRate;
double mPlaybackRate = 1.0;
Maybe<double> mPendingPlaybackRate;
// A Promise that is replaced on each call to Play()
@ -554,7 +546,7 @@ class Animation : public DOMEventTargetHelper,
// While ordering Animation objects for event dispatch, the index of the
// target node in its parent may be cached in mCachedChildIndex.
int32_t mCachedChildIndex;
int32_t mCachedChildIndex = -1;
// Indicates if the animation is in the pending state (and what state it is
// waiting to enter when it finished pending). We use this rather than
@ -563,23 +555,23 @@ class Animation : public DOMEventTargetHelper,
// from the PendingAnimationTracker while it is waiting for the next tick
// (see TriggerOnNextTick for details).
enum class PendingState : uint8_t { NotPending, PlayPending, PausePending };
PendingState mPendingState;
PendingState mPendingState = PendingState::NotPending;
bool mFinishedAtLastComposeStyle;
bool mFinishedAtLastComposeStyle = false;
// Indicates that the animation should be exposed in an element's
// getAnimations() list.
bool mIsRelevant;
bool mIsRelevant = false;
// True if mFinished is resolved or would be resolved if mFinished has
// yet to be created. This is not set when mFinished is rejected since
// in that case mFinished is immediately reset to represent a new current
// finished promise.
bool mFinishedIsResolved;
bool mFinishedIsResolved = false;
// True if this animation was triggered at the same time as one or more
// geometric animations and hence we should run any transform animations on
// the main thread.
bool mSyncWithGeometricAnimations;
bool mSyncWithGeometricAnimations = false;
RefPtr<MicroTaskRunnable> mFinishNotificationTask;