Bug 1665992 - Make vismet logs clearer and more informative. r=perftest-reviewers,Bebe

Differential Revision: https://phabricator.services.mozilla.com/D91042
This commit is contained in:
Gregory Mierzwinski 2020-09-23 12:01:00 +00:00
parent 845b0aa6d3
commit 6034ec9ed1

View File

@ -84,7 +84,12 @@ def run_command(log, cmd):
log.info("Command succeeded", result=res)
return 0, res
except subprocess.CalledProcessError as e:
log.info("Command failed", cmd=cmd, status=e.returncode, output=e.output)
log.info(
"[TEST-UNEXPECTED FAIL] Command failed",
cmd=cmd,
status=e.returncode,
output=e.output
)
return e.returncode, e.output
@ -351,7 +356,7 @@ def run_visual_metrics(job, visualmetrics_path, options):
Returns:
A returncode and a string containing the output of visualmetrics.py
"""
cmd = ["/usr/bin/python", str(visualmetrics_path), "--video", str(job.video_path)]
cmd = ["/usr/bin/python", str(visualmetrics_path), "-v", "--video", str(job.video_path)]
cmd.extend(options)
return run_command(log, cmd)