Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 12:55:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 858206 - Part 2: Don't use selectAtPoint for inputs as we already have collapsed one (caret). r=jimm

Browse Source
This commit is contained in:
Aleh Zasypkin 2014-03-06 22:35:28 +01:00
parent 83df7d3d14
commit 60c271084e
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
browser/metro/base/content/contenthandlers/SelectionHandler.js
View File

@ -118,13 +118,24 @@ var SelectionHandler = {
return;
}
// Similar to _onSelectionStart - we need to create initial selection
// but without the initialization bits.
let framePoint = this._clientPointToFramePoint({ xPos: aX, yPos: aY });
if (!this._domWinUtils.selectAtPoint(framePoint.xPos, framePoint.yPos,
Ci.nsIDOMWindowUtils.SELECT_CHARACTER)) {
this._onFail("failed to set selection at point");
return;
// Only use selectAtPoint for editable content and avoid that for inputs,
// as we can expand caret to selection manually more precisely. We can use
// selectAtPoint for inputs too though, but only once bug 881938 is fully
// resolved.
if(Util.isEditableContent(this._targetElement)) {
// Similar to _onSelectionStart - we need to create initial selection
// but without the initialization bits.
let framePoint = this._clientPointToFramePoint({ xPos: aX, yPos: aY });
if (!this._domWinUtils.selectAtPoint(framePoint.xPos, framePoint.yPos,
Ci.nsIDOMWindowUtils.SELECT_CHARACTER)) {
this._onFail("failed to set selection at point");
return;
}
} else if (this._targetElement.selectionStart == 0 || aMarker == "end") {
// Expand caret forward or backward depending on direction
this._targetElement.selectionEnd++;
} else {
this._targetElement.selectionStart--;
}
// We bail if things get out of sync here implying we missed a message.