From 6132198ccc76d35038537325820de53c541afb04 Mon Sep 17 00:00:00 2001
From: "robert%accettura.com" <robert%accettura.com>
Date: Fri, 23 Dec 2005 03:10:10 +0000
Subject: [PATCH] fix a few html validation issues

---
 tools/reporter/app/styles/style.css |  6 +-----
 tools/reporter/templates/index.tpl  | 26 ++++++++++++++------------
 tools/reporter/templates/layout.tpl |  5 +++--
 3 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/tools/reporter/app/styles/style.css b/tools/reporter/app/styles/style.css
index 8c6b1d7cf2c5..65d1086e2c5a 100644
--- a/tools/reporter/app/styles/style.css
+++ b/tools/reporter/app/styles/style.css
@@ -46,12 +46,8 @@ body, td, th, h3, input, pre { /* redundant rules for bad browsers  */
 	display: none;
 }
 
-
-#reporterSearch label {
+#reporterSearch .label, #reporterSearch label {
 	font-weight: bold;
-}
-
-#reporterSearch .label {
 	text-align: right;
 }
 
diff --git a/tools/reporter/templates/index.tpl b/tools/reporter/templates/index.tpl
index 61f685b092e0..d35f1567e48a 100644
--- a/tools/reporter/templates/index.tpl
+++ b/tools/reporter/templates/index.tpl
@@ -1,16 +1,18 @@
 <fieldset>
 	<legend>Look up Report</legend>
-	<form method="get" action ="{$app_url}/report/" ID="Form1">
-		<label for="report_id">Report ID</label>
-		<input type="text" id="report_id" name="report_id" />
-		<input type="submit" id="submit_reportID" name="submit_reportID" value="Lookup Report" />
+	<form method="get" action ="{$app_url}/report/" id="getReport">
+		<p>
+			<label for="report_id">Report ID</label>
+			<input type="text" id="report_id" name="report_id" />
+			<input type="submit" id="submit_reportID" name="submit_reportID" value="Lookup Report" />
+		</p>
 	</form>
 </fieldset>
 
 <!-- Query -->
 <fieldset>
 	<legend>Search for a Report</legend>
-	<form method="get" action="{$app_url}/query/">
+	<form method="get" action="{$app_url}/query/" id="detailQuery">
 	<table id="reporterSearch">
 		<tr>
 			<td class="label"><label for="report_description">Description:</label></td>
@@ -51,7 +53,7 @@
 						</td>
 					</tr>
 					<tr>
-						<td class="label"><label for="report_oscpu" title="oscpu">OS:</td>
+						<td class="label"><label for="report_oscpu" title="oscpu">OS:</label></td>
 						<td><input id="report_oscpu" name="report_oscpu" type="text" size="35" value="{$report_oscpu}"></td>
 					</tr>
 					<tr>
@@ -83,22 +85,22 @@
 			</td>
 		</tr>
 		<tr>
-			<td class="label"><label for="host_hostname">Host:</td>
+			<td class="label"><label for="host_hostname">Host:</label></td>
 			<td><input id="host_hostname" name="host_hostname" type="text" size="35" value="{$host_hostname}"></td>
 		</tr>
 		<tr>
 			<td class="label"><label for="report_problem_type">Problem Type:</label></td>
 			<td>
-				<input type="radio" name="report_problem_type" id="0" value="0" {if $report_problem_type == '0' || $report_problem_type == null}checked="true"{/if}><label for="0">All types</label><br>
+				<input type="radio" name="report_problem_type" id="0" value="0" {if $report_problem_type == '0' || $report_problem_type == null}checked="checked"{/if}><label for="0">All types</label><br>
 				{html_radios name="report_problem_type" options=$problem_types selected=$report_problem_type separator="<br />"}
 			</td>
 		</tr>
 		<tr>
-			<td class="label"><label for="report_behind_login">Site requires login:</label></td>
+			<td class="label">Site requires login:</td>
 			<td>
-				<input type="radio" name="report_behind_login" id="behind_login_null" value="-1" {if $report_behind_login == '-1' || $report_behind_login == ''}checked="true"{/if}><label for="behind_login_null">Any</label>
-				<input type="radio" name="report_behind_login" id="behind_login_yes" value="0" {if $report_behind_login == '0'}checked="true"{/if}><label for="behind_login_yes">Yes</label>
-				<input type="radio" name="report_behind_login" id="behind_login_no" value="1" {if $report_behind_login == '1'}checked="true"{/if}><label for="behind_login_no">No</label>
+				<input type="radio" name="report_behind_login" id="behind_login_null" value="-1" {if $report_behind_login == '-1' || $report_behind_login == ''}checked="checked"{/if}><label for="behind_login_null">Any</label>
+				<input type="radio" name="report_behind_login" id="behind_login_yes" value="0" {if $report_behind_login == '0'}checked="checked"{/if}><label for="behind_login_yes">Yes</label>
+				<input type="radio" name="report_behind_login" id="behind_login_no" value="1" {if $report_behind_login == '1'}checked="checked"{/if}><label for="behind_login_no">No</label>
 			</td>
 		</tr>
 		<tr>
diff --git a/tools/reporter/templates/layout.tpl b/tools/reporter/templates/layout.tpl
index 072392316b57..77009ec45d73 100644
--- a/tools/reporter/templates/layout.tpl
+++ b/tools/reporter/templates/layout.tpl
@@ -16,10 +16,11 @@
     <div id="mozilla-org"><a href="http://www.mozilla.org/">Visit Mozilla.org</a></div>
     <div id="header">
         <div id="logo">
+            {* for validation reasons two <a/> are used *}
             <a href="{$base_url}/app">
                 <img src="{$base_url}/app/img/reporter.gif" alt="Reporter" />
-                <h1>Mozilla Reporter</h1>
             </a>
+            <h1><a href="{$base_url}/app">Mozilla Reporter</a></h1>
         </div>
         <div id="navbox">
              <ul>
@@ -31,7 +32,7 @@
                      {/if}
                  {/strip}</li>
                  <li id="stats"><a href="{$base_url}/app/stats/" title="View Statistics">Stats</a></li>
-                 <li id="top_25"><a href="{$base_url}/app/query/?show=25&count=on&&submit_query=Search" title="Top 25 Hosts">Top 25</a></li>
+                 <li id="top_25"><a href="{$base_url}/app/query/?show=25&amp;count=on&amp;submit_query=Search" title="Top 25 Hosts">Top 25</a></li>
                  <li id="query"><a href="{$base_url}/app" title="Create a new Query">Query</a></li>
              </ul>
         </div>