Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1884208 - Remove negative probes for measuring delta between OnDataFinished and OnStopRequest in HttpChannelChild and HTML5Parser. r=jesup,necko-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D204057
This commit is contained in:
sunil mayya 2024-03-19 12:41:10 +00:00
parent fc141d95e9
commit 614fd58921
3 changed files with 8 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
netwerk/metrics.yaml
View File

@ -452,22 +452,6 @@ networking:
- rjesup@mozilla.com
expires: 130
http_content_ondatafinished_to_onstop_delay_negative:
type: timing_distribution
time_unit: millisecond
description: >
The time between processing OnStopRequest and processing OnDataFinished (if OnStopRequest comes first)
bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1857615
data_reviews:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1857615#c
data_sensitivity:
- technical
notification_emails:
- necko@mozilla.com
- rjesup@mozilla.com
expires: 130
http_content_html5parser_ondatafinished_to_onstop_delay:
type: timing_distribution
time_unit: millisecond
@ -484,22 +468,6 @@ networking:
- rjesup@mozilla.com
expires: 130
http_content_html5parser_ondatafinished_to_onstop_delay_negative:
type: timing_distribution
time_unit: millisecond
description: >
The time between processing OnStopRequest and processing OnDataFinished (if OnStopRequest comes first)
bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1857926
data_reviews:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1857926
data_sensitivity:
- technical
notification_emails:
- necko@mozilla.com
- rjesup@mozilla.com
expires: 130
http_content_cssloader_ondatafinished_to_onstop_delay:
type: timing_distribution
time_unit: millisecond

13
netwerk/protocol/http/HttpChannelChild.cpp
View File

@ -852,15 +852,10 @@ class RecordStopRequestDelta final {
}
TimeDuration delta = (mOnStopRequestTime - mOnDataFinishedTime);
if (delta.ToMilliseconds() < 0) {
// Because Telemetry can't handle negatives
delta = -delta;
glean::networking::http_content_ondatafinished_to_onstop_delay_negative
.AccumulateRawDuration(delta);
} else {
glean::networking::http_content_ondatafinished_to_onstop_delay
.AccumulateRawDuration(delta);
}
MOZ_ASSERT((delta.ToMilliseconds() >= 0),
"OnDataFinished after OnStopRequest");
glean::networking::http_content_ondatafinished_to_onstop_delay
.AccumulateRawDuration(delta);
}
};

14
parser/html/nsHtml5StreamParser.cpp
View File

@ -1421,16 +1421,10 @@ nsresult nsHtml5StreamParser::OnStopRequest(
}
if (!mOnStopRequestTime.IsNull() && !mOnDataFinishedTime.IsNull()) {
TimeDuration delta = (mOnStopRequestTime - mOnDataFinishedTime);
if (delta.ToMilliseconds() < 0) {
// Because Telemetry can't handle negatives
delta = -delta;
glean::networking::
http_content_html5parser_ondatafinished_to_onstop_delay_negative
.AccumulateRawDuration(delta);
} else {
glean::networking::http_content_html5parser_ondatafinished_to_onstop_delay
.AccumulateRawDuration(delta);
}
MOZ_ASSERT((delta.ToMilliseconds() >= 0),
"OnDataFinished after OnStopRequest");
glean::networking::http_content_html5parser_ondatafinished_to_onstop_delay
.AccumulateRawDuration(delta);
}
return NS_OK;
}