Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-01 14:45:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Need to sanity-check the index to avoid out-of-bounds array access. Bug

Browse Source 
180043, r=jkeiser, sr=alecf
This commit is contained in:
bzbarsky%mit.edu 2002-11-16 06:08:37 +00:00
parent 784c0dee7d
commit 61b20e92a9
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
content/base/src/nsDocument.cpp
View File

@ -1432,7 +1432,12 @@ nsDocument::SetRootContent(nsIContent* aRoot)
NS_IMETHODIMP
nsDocument::ChildAt(PRInt32 aIndex, nsIContent*& aResult) const
{
NS_IF_ADDREF(aResult = mChildren[aIndex]);
NS_PRECONDITION(aIndex >= 0, "Negative indices are bad");
if (aIndex < 0 || aIndex >= mChildren.Count()) {
aResult = nsnull;
} else {
NS_IF_ADDREF(aResult = mChildren[aIndex]);
}
return NS_OK;
}