Don't crash if someone pretends to be a form control (via XBL) without implementing

nsIFormControl.  Bug 260922, r+sr=jst
This commit is contained in:
bzbarsky%mit.edu 2004-09-30 19:15:59 +00:00
parent ec050b1d80
commit 61feb80622
2 changed files with 12 additions and 2 deletions

View File

@ -356,7 +356,12 @@ PRInt32
nsFormControlHelper::GetType(nsIContent* aContent)
{
nsCOMPtr<nsIFormControl> formControl(do_QueryInterface(aContent));
return formControl->GetType();
if (formControl) {
return formControl->GetType();
}
NS_ERROR("Form control not implementing nsIFormControl, assuming TEXT type");
return NS_FORM_INPUT_TEXT;
}
nsresult

View File

@ -356,7 +356,12 @@ PRInt32
nsFormControlHelper::GetType(nsIContent* aContent)
{
nsCOMPtr<nsIFormControl> formControl(do_QueryInterface(aContent));
return formControl->GetType();
if (formControl) {
return formControl->GetType();
}
NS_ERROR("Form control not implementing nsIFormControl, assuming TEXT type");
return NS_FORM_INPUT_TEXT;
}
nsresult