mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-28 20:55:39 +00:00
Bug 963046 - Use Picasso to load images in PanelListRow and PanelGridItemView (r=margaret)
This commit is contained in:
parent
80fa677593
commit
625b318e88
@ -8,10 +8,12 @@ package org.mozilla.gecko.home;
|
||||
import java.net.MalformedURLException;
|
||||
import java.net.URL;
|
||||
|
||||
import org.mozilla.gecko.db.BrowserContract.URLColumns;
|
||||
import org.mozilla.gecko.db.BrowserContract.HomeItems;
|
||||
import org.mozilla.gecko.favicons.Favicons;
|
||||
import org.mozilla.gecko.R;
|
||||
|
||||
import com.squareup.picasso.Picasso;
|
||||
|
||||
import android.content.Context;
|
||||
import android.database.Cursor;
|
||||
import android.graphics.Bitmap;
|
||||
@ -47,5 +49,12 @@ public class PanelGridItemView extends FrameLayout {
|
||||
mThumbnailView = (ImageView) findViewById(R.id.image);
|
||||
}
|
||||
|
||||
public void updateFromCursor(Cursor cursor) { }
|
||||
public void updateFromCursor(Cursor cursor) {
|
||||
int imageIndex = cursor.getColumnIndexOrThrow(HomeItems.IMAGE_URL);
|
||||
final String imageUrl = cursor.getString(imageIndex);
|
||||
|
||||
Picasso.with(getContext())
|
||||
.load(imageUrl)
|
||||
.into(mThumbnailView);
|
||||
}
|
||||
}
|
||||
|
@ -15,17 +15,22 @@ import org.mozilla.gecko.favicons.OnFaviconLoadedListener;
|
||||
import org.mozilla.gecko.util.ThreadUtils;
|
||||
import org.mozilla.gecko.widget.FaviconView;
|
||||
|
||||
import com.squareup.picasso.Picasso;
|
||||
|
||||
import android.content.Context;
|
||||
import android.database.Cursor;
|
||||
import android.graphics.Bitmap;
|
||||
import android.text.TextUtils;
|
||||
import android.util.AttributeSet;
|
||||
import android.view.View;
|
||||
import android.widget.ImageView;
|
||||
|
||||
import java.lang.ref.WeakReference;
|
||||
|
||||
public class PanelListRow extends TwoLineRow {
|
||||
|
||||
private final ImageView mIcon;
|
||||
|
||||
public PanelListRow(Context context) {
|
||||
this(context, null);
|
||||
}
|
||||
@ -33,10 +38,7 @@ public class PanelListRow extends TwoLineRow {
|
||||
public PanelListRow(Context context, AttributeSet attrs) {
|
||||
super(context, attrs);
|
||||
|
||||
// XXX: Never show icon for now. We have to figure out
|
||||
// how the images will be passed through the cursor.
|
||||
final View iconView = findViewById(R.id.icon);
|
||||
iconView.setVisibility(View.GONE);
|
||||
mIcon = (ImageView) findViewById(R.id.icon);
|
||||
}
|
||||
|
||||
@Override
|
||||
@ -55,5 +57,13 @@ public class PanelListRow extends TwoLineRow {
|
||||
int urlIndex = cursor.getColumnIndexOrThrow(HomeItems.URL);
|
||||
final String url = cursor.getString(urlIndex);
|
||||
setSecondaryText(url);
|
||||
|
||||
int imageIndex = cursor.getColumnIndexOrThrow(HomeItems.IMAGE_URL);
|
||||
final String imageUrl = cursor.getString(imageIndex);
|
||||
|
||||
Picasso.with(getContext())
|
||||
.load(imageUrl)
|
||||
.error(R.drawable.favicon)
|
||||
.into(mIcon);
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user