Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 23:02:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1775516 - Audit android_system_properties. r=bholley

Browse Source 
We initially depended on the android_property crate, however it causes build errors on old versions of Android which we support. I'm hopeful that the upstream crate will accept my submitted fixes, in the mean time I rewrote it and stripped it down to the minimum required featureset, to unblock us.
The new code is very small: f59b510fd8/src/lib.rs The interesting parts are ported from https://searchfox.org/mozilla-central/rev/b7642d0089449244d6361680bc619c94bf11725f/intl/icu/source/common/putil.cpp#1082 which we already ship, with extra utf8 checks.

jimb gave it a review.

Differential Revision: https://phabricator.services.mozilla.com/D150021
This commit is contained in:
Nicolas Silva 2022-06-28 17:45:53 +00:00
parent 2e9b249a8d
commit 62b57953f6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
supply-chain/audits.toml
View File

@ -1,6 +1,12 @@
# cargo-vet audits file
[[audits.android_system_properties]]
who = "Nicolas Silva <nical@fastmail.com>"
criteria = "safe-to-deploy"
version = "0.1.2"
notes = "I wrote this crate, reviewed by jimb. It is mostly a Rust port of some C++ code we already ship."
[[audits.arbitrary]]
who = "Mike Hommey <mh+mozilla@glandium.org>"
criteria = "safe-to-run"