Bug 1552286 - Fix Checkstyle errors on GeckoJavaSampler r=nalexander

Differential Revision: https://phabricator.services.mozilla.com/D33522

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Nazım Can Altınova 2019-06-05 10:58:28 +00:00
parent 8add76ec66
commit 62d3f06e55

View File

@ -13,7 +13,6 @@ import android.util.SparseArray;
import org.mozilla.gecko.annotation.WrapForJNI;
import java.lang.Thread;
import java.util.Set;
public class GeckoJavaSampler {
private static final String LOGTAG = "JavaSampler";
@ -30,7 +29,7 @@ public class GeckoJavaSampler {
public Frame[] mFrames;
public double mTime;
public long mJavaTime; // non-zero if Android system time is used
public Sample(StackTraceElement[] aStack) {
public Sample(final StackTraceElement[] aStack) {
mFrames = new Frame[aStack.length];
if (GeckoThread.isStateAtLeast(GeckoThread.State.JNI_READY)) {
mTime = getProfilerTime();
@ -105,7 +104,7 @@ public class GeckoJavaSampler {
}
}
private Sample getSample(int aThreadId, int aSampleId) {
private Sample getSample(final int aThreadId, final int aSampleId) {
if (aThreadId < mSamples.size() && aSampleId < mSamples.get(aThreadId).length &&
mSamples.get(aThreadId)[aSampleId] != null) {
int startPos = 0;
@ -121,19 +120,19 @@ public class GeckoJavaSampler {
@WrapForJNI
public synchronized static String getThreadName(int aThreadId) {
public synchronized static String getThreadName(final int aThreadId) {
if (aThreadId == 0 && sMainThread != null) {
return sMainThread.getName();
}
return null;
}
private synchronized static Sample getSample(int aThreadId, int aSampleId) {
private synchronized static Sample getSample(final int aThreadId, final int aSampleId) {
return sSamplingRunnable.getSample(aThreadId, aSampleId);
}
@WrapForJNI
public synchronized static double getSampleTime(int aThreadId, int aSampleId) {
public synchronized static double getSampleTime(final int aThreadId, final int aSampleId) {
Sample sample = getSample(aThreadId, aSampleId);
if (sample != null) {
if (sample.mJavaTime != 0) {
@ -146,7 +145,7 @@ public class GeckoJavaSampler {
}
@WrapForJNI
public synchronized static String getFrameName(int aThreadId, int aSampleId, int aFrameId) {
public synchronized static String getFrameName(final int aThreadId, final int aSampleId, final int aFrameId) {
Sample sample = getSample(aThreadId, aSampleId);
if (sample != null && aFrameId < sample.mFrames.length) {
Frame frame = sample.mFrames[aFrameId];
@ -159,7 +158,7 @@ public class GeckoJavaSampler {
}
@WrapForJNI
public static void start(int aInterval, int aSamples) {
public static void start(final int aInterval, final int aSamples) {
synchronized (GeckoJavaSampler.class) {
if (sSamplingRunnable != null) {
return;