Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 00:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't cache the result of GetPointFromOffset if it failed, since subsequent queries for that offset will return the bogus offset. bug 334608, r+sr=roc

Browse Source
This commit is contained in:
mrbkap%gmail.com 2006-04-24 21:18:44 +00:00
parent add20431b9
commit 62fd40b6c4
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
layout/generic/nsSelection.cpp
View File

@ -1,4 +1,5 @@
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=2 sw=2 et tw=78: */
/* ***** BEGIN LICENSE BLOCK *****
* Version: MPL 1.1/GPL 2.0/LGPL 2.1
*
@ -5065,9 +5066,10 @@ nsTypedSelection::GetCachedFrameOffset(nsIFrame *aFrame, PRInt32 inOffset, nsPoi
}
else
{
// recalculate frame offset and cache it
GetPointFromOffset(aFrame, inOffset, &aPoint);
if (mCachedOffsetForFrame->mCanCacheFrameOffset) {
// Recalculate frame offset and cache it. Don't cache a frame offset if
// GetPointFromOffset fails, though.
nsresult rv = GetPointFromOffset(aFrame, inOffset, &aPoint);
if (NS_SUCCEEDED(rv) && mCachedOffsetForFrame->mCanCacheFrameOffset) {
mCachedOffsetForFrame->mCachedFrameOffset = aPoint;
mCachedOffsetForFrame->mLastCaretFrame = aFrame;
mCachedOffsetForFrame->mLastContentOffset = inOffset;