Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1354713 - Make use of the application reputation allow list on OSX and Linux. r=gcp

Browse Source 
Since the allow list contains both hostnames and certificate hashes, it makes sense
to use it on all platforms.

MozReview-Commit-ID: 1icRFYhhnAY

--HG--
extra : rebase_source : bcb6113090546cdca2b4f2dd120db98ffb511b0d
This commit is contained in:
Francois Marier 2017-04-07 16:07:41 -07:00
parent f9d7bab84d
commit 6321486d37
2 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/libpref/init/all.js
View File

@ -5172,25 +5172,13 @@ pref("urlclassifier.phishTable", "googpub-phish-shavar,test-phish-simple");
// Tables for application reputation.
#ifdef NIGHTLY_BUILD
pref("urlclassifier.downloadAllowTable", "goog-downloadwhite-digest256,goog-downloadwhite-proto");
pref("urlclassifier.downloadBlockTable", "goog-badbinurl-shavar,goog-badbinurl-proto");
#else
pref("urlclassifier.downloadBlockTable", "goog-badbinurl-shavar");
#endif
#ifdef XP_WIN
// Only download the whitelist on Windows, since the whitelist is
// only useful for suppressing remote lookups for signed binaries which we can
// only verify on Windows (Bug 974579). Other platforms always do remote lookups.
#ifdef NIGHTLY_BUILD
pref("urlclassifier.downloadAllowTable", "goog-downloadwhite-digest256,goog-downloadwhite-proto");
#else
pref("urlclassifier.downloadAllowTable", "goog-downloadwhite-digest256");
pref("urlclassifier.downloadBlockTable", "goog-badbinurl-shavar");
#endif // NIGHTLY_BUILD
#else
pref("urlclassifier.downloadAllowTable", "");
#endif // XP_WIN
pref("urlclassifier.disallow_completions", "test-malware-simple,test-phish-simple,test-unwanted-simple,test-track-simple,test-trackwhite-simple,test-block-simple,test-flashallow-simple,testexcept-flashallow-simple,test-flash-simple,testexcept-flash-simple,test-flashsubdoc-simple,testexcept-flashsubdoc-simple,goog-downloadwhite-digest256,base-track-digest256,mozstd-trackwhite-digest256,content-track-digest256,mozplugin-block-digest256,mozplugin2-block-digest256,block-flash-digest256,except-flash-digest256,allow-flashallow-digest256,except-flashallow-digest256,block-flashsubdoc-digest256,except-flashsubdoc-digest256");
// The table and update/gethash URLs for Safebrowsing phishing and malware

3
toolkit/components/downloads/ApplicationReputation.cpp
View File

@ -1284,8 +1284,6 @@ PendingLookup::SendRemoteQueryInternal()
return NS_ERROR_NOT_AVAILABLE;
}
}
#ifdef XP_WIN
// The allowlist is only needed to do signature verification on Windows
{
nsAutoCString table;
NS_ENSURE_SUCCESS(Preferences::GetCString(PREF_DOWNLOAD_ALLOW_TABLE,
@ -1296,7 +1294,6 @@ PendingLookup::SendRemoteQueryInternal()
return NS_ERROR_NOT_AVAILABLE;
}
}
#endif
LOG(("Sending remote query for application reputation [this = %p]",
this));