Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1565055. Use USVString in window.open(). r=peterv

Browse Source 
Of course there's no wpt coverage for this... :(

Differential Revision: https://phabricator.services.mozilla.com/D37666

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Boris Zbarsky 2019-07-11 16:31:34 +00:00
parent d2092df77a
commit 6474e0a0f2
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/webidl/Document.webidl
View File

@ -147,10 +147,8 @@ partial interface Document {
// dynamic markup insertion
[CEReactions, Throws]
Document open(optional DOMString unused1, optional DOMString unused2); // both arguments are ignored
// "url" should be USVString, but we should change that when we
// change window.open.
[CEReactions, Throws]
WindowProxy? open(DOMString url, DOMString name, DOMString features);
WindowProxy? open(USVString url, DOMString name, DOMString features);
[CEReactions, Throws]
void close();
[CEReactions, Throws]

3
dom/webidl/Window.webidl
View File

@ -62,9 +62,8 @@ typedef OfflineResourceList ApplicationCache;
//[Throws] readonly attribute WindowProxy parent;
[Replaceable, Throws, CrossOriginReadable] readonly attribute WindowProxy? parent;
[Throws, NeedsSubjectPrincipal] readonly attribute Element? frameElement;
// When we fix "url" to be USVString, we should update document.open() too.
//[Throws] WindowProxy? open(optional USVString url = "about:blank", optional DOMString target = "_blank", [TreatNullAs=EmptyString] optional DOMString features = "");
[Throws] WindowProxy? open(optional DOMString url = "", optional DOMString target = "", optional [TreatNullAs=EmptyString] DOMString features = "");
[Throws] WindowProxy? open(optional USVString url = "", optional DOMString target = "", optional [TreatNullAs=EmptyString] DOMString features = "");
getter object (DOMString name);
// the user agent