Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-22 18:32:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bug 281133 - Add Bookmark fails for page without a title. Test to see if we have a page title before adding to the dict.

Browse Source
This commit is contained in:
smfr%smfr.org 2005-04-02 17:37:15 +00:00
parent ee87507218
commit 6562c84def
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
camino/src/browser/BrowserWindowController.mm
View File

@ -1899,16 +1899,15 @@ enum BWCOpenDest {
NSString* hrefString = nil;
[self bookmarkableTitle:&curTitleString URL:&hrefString forWrapper:browserWrapper];
NSMutableDictionary* itemInfo = [NSMutableDictionary dictionaryWithObjectsAndKeys:
curTitleString, kAddBookmarkItemTitleKey,
hrefString, kAddBookmarkItemURLKey,
nil];
NSMutableDictionary* itemInfo = [NSMutableDictionary dictionaryWithObject:hrefString forKey:kAddBookmarkItemURLKey];
if (browserWrapper == mBrowserView)
{
[itemInfo setObject:[NSNumber numberWithBool:YES] forKey:kAddBookmarkItemPrimaryTabKey];
}
// titlel can be nil (e.g. for text files)
if (curTitleString)
[itemInfo setObject:curTitleString forKey:kAddBookmarkItemTitleKey];
if (browserWrapper == mBrowserView)
[itemInfo setObject:[NSNumber numberWithBool:YES] forKey:kAddBookmarkItemPrimaryTabKey];
[itemsArray addObject:itemInfo];
}