Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1555786 - Get inner window from doc directly for resize observer. r=smaug

Browse Source 
In Notify(), we should guarantee that the inner window we get is for the
document, and avoid using null outer window pointer.

Differential Revision: https://phabricator.services.mozilla.com/D35727

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Boris Chiou 2019-06-25 20:07:03 +00:00
parent 75691588ac
commit 65d67a409f
3 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dom/base/ResizeObserverController.cpp
View File

@ -147,10 +147,7 @@ void ResizeObserverController::Notify() {
nsEventStatus status = nsEventStatus_eIgnore;
nsCOMPtr<nsPIDOMWindowInner> window =
doc->GetWindow()->GetCurrentInnerWindow();
if (window) {
if (nsCOMPtr<nsPIDOMWindowInner> window = doc->GetInnerWindow()) {
nsCOMPtr<nsIScriptGlobalObject> sgo = do_QueryInterface(window);
MOZ_ASSERT(sgo);

23
dom/base/crashtests/1555786.html Normal file
View File

@ -0,0 +1,23 @@
<html>
<head>
<script>
function start() {
const xhr = new XMLHttpRequest();
const observer = new ResizeObserver(entries => {
xhr.open('GET', '', false);
xhr.send();
typeof entries[0].borderBoxSize;
typeof entries[0].contentRect;
typeof entries[0].borderBoxSize;
})
observer.observe(document.getElementById('list'), {});
window.close();
}
document.addEventListener('DOMContentLoaded', start);
</script>
</head>
<body>
<li class="" id="list">
</body>
</html>

1
dom/base/crashtests/crashtests.list
View File

@ -250,3 +250,4 @@ load structured_clone_container_throws.html
load xhr_empty_datauri.html
load xhr_html_nullresponse.html
load xhr-with-pagehide-1.html
pref(layout.css.resizeobserver.enabled,true) load 1555786.html