Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 00:35:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug 1555392 - remove unnecessary things from test_cert_storage.js that were causing intermittent failures r=KevinJacobs

Browse Source 
At some point in the past, test_cert_storage.js needed to initialize the add-on
system to start the blocklist system, which is where revocation updates used to
come from. This appears to no longer be the case and the code in question can be
removed (and it should be removed because it's causing intermittent failures).

Differential Revision: https://phabricator.services.mozilla.com/D33993

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Dana Keeler 2019-06-06 21:11:25 +00:00
parent 37ebd39e5c
commit 66f092c690
1 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
security/manager/ssl/tests/unit/test_cert_storage.js
View File

@ -12,24 +12,8 @@
// * it does a sanity check to ensure other cert verifier behavior is
// unmodified
const { setTimeout } = ChromeUtils.import("resource://gre/modules/Timer.jsm", {});
const { RemoteSettings } = ChromeUtils.import("resource://services-settings/remote-settings.js", {});
const { BlocklistClients } = ChromeUtils.import("resource://services-common/blocklist-clients.js", {});
// First, we need to setup appInfo for the blocklist service to work
var id = "xpcshell@tests.mozilla.org";
var appName = "XPCShell";
var version = "1";
var platformVersion = "1.9.2";
ChromeUtils.import("resource://testing-common/AppInfo.jsm", this);
/* global updateAppInfo:false */ // Imported via AppInfo.jsm.
updateAppInfo({
name: appName,
ID: id,
version,
platformVersion: platformVersion ? platformVersion : "1.0",
crashReporter: true,
});
const { RemoteSettings } = ChromeUtils.import("resource://services-settings/remote-settings.js");
const { BlocklistClients } = ChromeUtils.import("resource://services-common/blocklist-clients.js");
// we need to ensure we setup revocation data before certDB, or we'll start with
// no revocation.txt in the profile
@ -98,12 +82,6 @@ const certBlocklist = [
},
];
// Setup the addonManager
var addonManager = Cc["@mozilla.org/addons/integration;1"]
.getService(Ci.nsIObserver)
.QueryInterface(Ci.nsITimerCallback);
addonManager.observe(null, "addons-startup", null);
function verify_cert(file, expectedError) {
let ee = constructCertFromFile(file);
return checkCertErrorGeneric(certDB, ee, expectedError,