Bug 930674 - convert VISIBILITY_FLAGS in Makefile.in to NO_VISIBILITY_FLAGS in moz.build. r=mshal

2024-11-27 23:02:20 +00:00 · 2013-10-24 15:06:19 -04:00 · 2013-10-24 15:06:19 -04:00 · 673fd74516
commit 673fd74516
parent cdc3f39de8
40 changed files with 50 additions and 59 deletions
--- a/config/Makefile.in
+++ b/config/Makefile.in
@ -4,10 +4,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-# For sanity's sake, we compile nsinstall without the wrapped system
-# headers, so that we can use it to set up the wrapped system headers.
-VISIBILITY_FLAGS =
-
 # STDCXX_COMPAT is not needed here, and will actually fail because
 # libstdc++-compat is not built yet.
 MOZ_LIBSTDCXX_HOST_VERSION =
--- a/config/moz.build
+++ b/config/moz.build
@ -5,6 +5,9 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 NO_DIST_INSTALL = True
+# For sanity's sake, we compile nsinstall without the wrapped system
+# headers, so that we can use it to set up the wrapped system headers.
+NO_VISIBILITY_FLAGS = True

 CONFIGURE_SUBST_FILES += [
    'autoconf.mk',
--- a/db/sqlite3/src/Makefile.in
+++ b/db/sqlite3/src/Makefile.in
@ -7,7 +7,6 @@ SHORT_LIBNAME    = mozsqlt3
 ifndef MOZ_FOLD_LIBS
 FORCE_SHARED_LIB = 1
 endif
-VISIBILITY_FLAGS =
 LIB_IS_C_ONLY    = 1

 ifeq ($(OS_ARCH),WINNT)
--- a/db/sqlite3/src/moz.build
+++ b/db/sqlite3/src/moz.build
@ -5,6 +5,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 MODULE = 'sqlite3'
+NO_VISIBILITY_FLAGS = True

 EXPORTS += [
    'sqlite3.h',
--- a/gfx/angle/Makefile.in
+++ b/gfx/angle/Makefile.in
@ -2,10 +2,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif
-
 # The below is a rough translation of build_angle.gypi:
 DEFINES += -DANGLE_DISABLE_TRACE
 DEFINES += -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1
--- a/gfx/angle/moz.build
+++ b/gfx/angle/moz.build
@ -120,3 +120,6 @@ SOURCES += ['src/compiler/' + src for src in [
 LIBRARY_NAME = 'angle'
 LIBXUL_LIBRARY = True
 MSVC_ENABLE_PGO = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/gfx/graphite2/src/Makefile.in
+++ b/gfx/graphite2/src/Makefile.in
@ -16,7 +16,6 @@ include $(srcdir)/files.mk

 # on Windows, we're going to link graphite with gkmedias instead of libxul
 ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
 endif

 ifeq (WINNT,$(OS_TARGET))
--- a/gfx/graphite2/src/moz.build
+++ b/gfx/graphite2/src/moz.build
@ -66,3 +66,5 @@ LIBRARY_NAME = 'mozgraphite2'

 MSVC_ENABLE_PGO = True

+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/gfx/ots/src/Makefile.in
+++ b/gfx/ots/src/Makefile.in
@ -26,7 +26,6 @@


 ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
 endif

 CSRCS =   \
--- a/gfx/ots/src/moz.build
+++ b/gfx/ots/src/moz.build
@ -54,3 +54,5 @@ LIBRARY_NAME = 'mozots'

 MSVC_ENABLE_PGO = True

+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/js/src/config/Makefile.in
+++ b/js/src/config/Makefile.in
@ -3,10 +3,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-# For sanity's sake, we compile nsinstall without the wrapped system
-# headers, so that we can use it to set up the wrapped system headers.
-VISIBILITY_FLAGS =
-
 ifneq (WINNT,$(HOST_OS_ARCH))
 HOST_PROGRAM	= nsinstall_real$(HOST_BIN_SUFFIX)
 endif
--- a/js/src/config/moz.build
+++ b/js/src/config/moz.build
@ -5,6 +5,9 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 NO_DIST_INSTALL = True
+# For sanity's sake, we compile nsinstall without the wrapped system
+# headers, so that we can use it to set up the wrapped system headers.
+NO_VISIBILITY_FLAGS = True

 if CONFIG['HOST_OS_ARCH'] != 'WINNT':
    HOST_SOURCES += [
--- a/media/kiss_fft/Makefile.in
+++ b/media/kiss_fft/Makefile.in
@ -1,7 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif
--- a/media/kiss_fft/moz.build
+++ b/media/kiss_fft/moz.build
@ -18,3 +18,5 @@ SOURCES += [

 LIBRARY_NAME = 'kiss_fft'

+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libcubeb/src/Makefile.in
+++ b/media/libcubeb/src/Makefile.in
@ -2,9 +2,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq ($(OS_TARGET),WINNT)
-VISIBILITY_FLAGS =
-endif

 ifeq ($(OS_TARGET),WINNT)
 DEFINES         += -DUSE_WINMM -DUSE_WASAPI
--- a/media/libcubeb/src/moz.build
+++ b/media/libcubeb/src/moz.build
@ -52,3 +52,6 @@ LIBRARY_NAME = 'cubeb'
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libjpeg/Makefile.in
+++ b/media/libjpeg/Makefile.in
@ -3,10 +3,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq ($(OS_ARCH),WINNT)
-VISIBILITY_FLAGS	=
-endif
-
 AS=$(LIBJPEG_TURBO_AS)
 ASM_SUFFIX=asm
 ASFLAGS=$(LIBJPEG_TURBO_ASFLAGS) -I$(topsrcdir)/media/libjpeg/simd/
--- a/media/libjpeg/moz.build
+++ b/media/libjpeg/moz.build
@ -152,3 +152,6 @@ MSVC_ENABLE_PGO = True

 # need static lib for some of the libimg componentry to link properly
 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libnestegg/src/Makefile.in
+++ b/media/libnestegg/src/Makefile.in
@ -2,6 +2,3 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif
--- a/media/libnestegg/src/moz.build
+++ b/media/libnestegg/src/moz.build
@ -16,3 +16,6 @@ LIBRARY_NAME = 'nestegg'
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libogg/src/Makefile.in
+++ b/media/libogg/src/Makefile.in
@ -2,6 +2,3 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif
--- a/media/libogg/src/moz.build
+++ b/media/libogg/src/moz.build
@ -16,3 +16,6 @@ LIBRARY_NAME = 'ogg'
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libpng/Makefile.in
+++ b/media/libpng/Makefile.in
@ -3,6 +3,3 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq ($(OS_ARCH),WINNT)
-VISIBILITY_FLAGS=
-endif
--- a/media/libpng/moz.build
+++ b/media/libpng/moz.build
@ -50,3 +50,6 @@ LIBRARY_NAME = 'mozpng'
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libsoundtouch/src/Makefile.in
+++ b/media/libsoundtouch/src/Makefile.in
@ -3,7 +3,6 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 SHORT_LIBNAME = soundt
-VISIBILITY_FLAGS =
 EXTRA_DSO_LDOPTS += $(MOZALLOC_LIB)

 # Use abort() instead of exception in SoundTouch.
--- a/media/libsoundtouch/src/moz.build
+++ b/media/libsoundtouch/src/moz.build
@ -36,4 +36,4 @@ if CONFIG['INTEL_ARCHITECTURE']:
 LIBRARY_NAME = 'soundtouch'

 MSVC_ENABLE_PGO = True
-
+NO_VISIBILITY_FLAGS = True
--- a/media/libtheora/lib/Makefile.in
+++ b/media/libtheora/lib/Makefile.in
@ -2,9 +2,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif

 # The encoder is currently not included.
 DEFINES += -DTHEORA_DISABLE_ENCODE
--- a/media/libtheora/lib/moz.build
+++ b/media/libtheora/lib/moz.build
@ -27,3 +27,6 @@ SOURCES += [
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libvorbis/lib/Makefile.in
+++ b/media/libvorbis/lib/Makefile.in
@ -2,9 +2,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif

 ifeq ($(OS_ARCH),AIX)
 DEFINES += -Dalloca=__alloca
--- a/media/libvorbis/lib/moz.build
+++ b/media/libvorbis/lib/moz.build
@ -34,3 +34,6 @@ SOURCES += [
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/libvpx/Makefile.in
+++ b/media/libvpx/Makefile.in
@ -5,9 +5,6 @@

 DEFINES += -DHAVE_CONFIG_H=vpx_config.h

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif

 LOCAL_INCLUDES += \
  -I. \
--- a/media/libvpx/moz.build
+++ b/media/libvpx/moz.build
@ -93,3 +93,6 @@ SOURCES += [
 MSVC_ENABLE_PGO = True

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/mtransport/build/Makefile.in
+++ b/media/mtransport/build/Makefile.in
@ -3,10 +3,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif
-
 DEFINES += -DHAVE_STRDUP -DNR_SOCKET_IS_VOID_PTR

 ifneq (,$(filter Darwin DragonFly FreeBSD NetBSD OpenBSD,$(OS_TARGET)))
--- a/media/mtransport/build/moz.build
+++ b/media/mtransport/build/moz.build
@ -71,3 +71,6 @@ elif CONFIG['OS_TARGET'] == 'WINNT':
    LOCAL_INCLUDES += [
        '/media/mtransport/third_party/nrappkit/src/port/win32/include',
    ]
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/media/mtransport/standalone/Makefile.in
+++ b/media/mtransport/standalone/Makefile.in
@ -3,9 +3,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-ifeq (WINNT,$(OS_TARGET))
-VISIBILITY_FLAGS =
-endif

 DEFINES += -DHAVE_STRDUP -DNR_SOCKET_IS_VOID_PTR

--- a/media/mtransport/standalone/moz.build
+++ b/media/mtransport/standalone/moz.build
@ -51,3 +51,6 @@ elif CONFIG['OS_TARGET'] == 'WINNT':
    ]

 FORCE_STATIC_LIB = True
+
+if CONFIG['OS_TARGET'] == 'WINNT':
+    NO_VISIBILITY_FLAGS = True
--- a/memory/mozalloc/Makefile.in
+++ b/memory/mozalloc/Makefile.in
@ -3,7 +3,6 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

-VISIBILITY_FLAGS=
 STL_FLAGS	=
 ifdef _MSC_VER
 STL_FLAGS	= -D_HAS_EXCEPTIONS=0
--- a/memory/mozalloc/moz.build
+++ b/memory/mozalloc/moz.build
@ -5,6 +5,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 MODULE = 'mozalloc'
+NO_VISIBILITY_FLAGS = True

 EXPORTS.mozilla += [
    'fallible.h',
--- a/mozglue/build/Makefile.in
+++ b/mozglue/build/Makefile.in
@ -15,8 +15,6 @@ endif
 ifeq (1_1,$(MOZ_MEMORY)_$(or $(MOZ_NATIVE_JEMALLOC),$(FORCE_SHARED_LIB)))
 SHARED_LIBRARY_LIBS = $(call EXPAND_LIBNAME_PATH,memory,$(DEPTH)/memory/build)
 else
-# Temporary, until bug 662814 lands
-VISIBILITY_FLAGS =

 ifneq (,$(filter OS2 WINNT,$(OS_ARCH)))
 SDK_LIBRARY = $(IMPORT_LIBRARY)
--- a/mozglue/build/moz.build
+++ b/mozglue/build/moz.build
@ -20,6 +20,8 @@ if CONFIG['MOZ_MEMORY'] and (CONFIG['MOZ_NATIVE_JEMALLOC'] or force_shared_lib):
    pass
    # TODO: SHARED_LIBRARY_LIBS go here
 else:
+    # Temporary, until bug 662814 lands
+    NO_VISIBILITY_FLAGS = True
    SOURCES += [
        'dummy.cpp',
    ]