Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 11:25:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1669161 - Remove dead SVG event code r=smaug

Browse Source 
-  onSVGZoom is gone and we no longer dispatch it.
- we've never dispatched SVGUnload or SVGResize events and if we did implement these they would be unload and resize events now.

Differential Revision: https://phabricator.services.mozilla.com/D92381
This commit is contained in:
longsonr 2020-10-05 11:19:47 +00:00
parent 800c1729b5
commit 67be8b29cb
5 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/events/EventListenerManager.cpp
View File

@ -923,14 +923,8 @@ nsresult EventListenerManager::CompileEventHandlerInternal(
if (!aBody) { if (!aBody) {
if (aListener->mTypeAtom == nsGkAtoms::onSVGLoad) { if (aListener->mTypeAtom == nsGkAtoms::onSVGLoad) {
attrName = nsGkAtoms::onload; attrName = nsGkAtoms::onload;
} else if (aListener->mTypeAtom == nsGkAtoms::onSVGUnload) {
attrName = nsGkAtoms::onunload;
} else if (aListener->mTypeAtom == nsGkAtoms::onSVGResize) {
attrName = nsGkAtoms::onresize;
} else if (aListener->mTypeAtom == nsGkAtoms::onSVGScroll) { } else if (aListener->mTypeAtom == nsGkAtoms::onSVGScroll) {
attrName = nsGkAtoms::onscroll; attrName = nsGkAtoms::onscroll;
} else if (aListener->mTypeAtom == nsGkAtoms::onSVGZoom) {
attrName = nsGkAtoms::onzoom;
} else if (aListener->mTypeAtom == nsGkAtoms::onbeginEvent) { } else if (aListener->mTypeAtom == nsGkAtoms::onbeginEvent) {
attrName = nsGkAtoms::onbegin; attrName = nsGkAtoms::onbegin;
} else if (aListener->mTypeAtom == nsGkAtoms::onrepeatEvent) { } else if (aListener->mTypeAtom == nsGkAtoms::onrepeatEvent) {

2
dom/events/EventNameList.h
View File

@ -429,8 +429,6 @@ NON_IDL_EVENT(underflow, eScrollPortUnderflow, EventNameType_XUL,
// Various SVG events // Various SVG events
NON_IDL_EVENT(SVGLoad, eSVGLoad, EventNameType_None, eBasicEventClass) NON_IDL_EVENT(SVGLoad, eSVGLoad, EventNameType_None, eBasicEventClass)
NON_IDL_EVENT(SVGUnload, eSVGUnload, EventNameType_None, eBasicEventClass)
NON_IDL_EVENT(SVGResize, eSVGResize, EventNameType_None, eBasicEventClass)
NON_IDL_EVENT(SVGScroll, eSVGScroll, EventNameType_None, eBasicEventClass) NON_IDL_EVENT(SVGScroll, eSVGScroll, EventNameType_None, eBasicEventClass)
// Only map the ID to the real event name when MESSAGE_TO_EVENT is defined. // Only map the ID to the real event name when MESSAGE_TO_EVENT is defined.

3
dom/svg/SVGElement.cpp
View File

@ -1391,10 +1391,7 @@ void SVGElement::MaybeSerializeAttrBeforeRemoval(nsAtom* aName, bool aNotify) {
/* static */ /* static */
nsAtom* SVGElement::GetEventNameForAttr(nsAtom* aAttr) { nsAtom* SVGElement::GetEventNameForAttr(nsAtom* aAttr) {
if (aAttr == nsGkAtoms::onload) return nsGkAtoms::onSVGLoad; if (aAttr == nsGkAtoms::onload) return nsGkAtoms::onSVGLoad;
if (aAttr == nsGkAtoms::onunload) return nsGkAtoms::onSVGUnload;
if (aAttr == nsGkAtoms::onresize) return nsGkAtoms::onSVGResize;
if (aAttr == nsGkAtoms::onscroll) return nsGkAtoms::onSVGScroll; if (aAttr == nsGkAtoms::onscroll) return nsGkAtoms::onSVGScroll;
if (aAttr == nsGkAtoms::onzoom) return nsGkAtoms::onSVGZoom;
if (aAttr == nsGkAtoms::onbegin) return nsGkAtoms::onbeginEvent; if (aAttr == nsGkAtoms::onbegin) return nsGkAtoms::onbeginEvent;
if (aAttr == nsGkAtoms::onrepeat) return nsGkAtoms::onrepeatEvent; if (aAttr == nsGkAtoms::onrepeat) return nsGkAtoms::onrepeatEvent;
if (aAttr == nsGkAtoms::onend) return nsGkAtoms::onendEvent; if (aAttr == nsGkAtoms::onend) return nsGkAtoms::onendEvent;

5
widget/EventMessageList.h
View File

@ -229,13 +229,8 @@ NS_EVENT_MESSAGE(ePageHide)
// SVG events // SVG events
NS_EVENT_MESSAGE(eSVGLoad) NS_EVENT_MESSAGE(eSVGLoad)
NS_EVENT_MESSAGE(eSVGUnload)
NS_EVENT_MESSAGE(eSVGResize)
NS_EVENT_MESSAGE(eSVGScroll) NS_EVENT_MESSAGE(eSVGScroll)
// SVG Zoom events
NS_EVENT_MESSAGE(eSVGZoom)
// XUL command events // XUL command events
NS_EVENT_MESSAGE(eXULCommand) NS_EVENT_MESSAGE(eXULCommand)

3
xpcom/ds/StaticAtoms.py
View File

@ -1460,10 +1460,7 @@ STATIC_ATOMS = [
Atom("objectBoundingBox", "objectBoundingBox"), Atom("objectBoundingBox", "objectBoundingBox"),
Atom("offset", "offset"), Atom("offset", "offset"),
Atom("onSVGLoad", "onSVGLoad"), Atom("onSVGLoad", "onSVGLoad"),
Atom("onSVGResize", "onSVGResize"),
Atom("onSVGScroll", "onSVGScroll"), Atom("onSVGScroll", "onSVGScroll"),
Atom("onSVGUnload", "onSVGUnload"),
Atom("onSVGZoom", "onSVGZoom"),
Atom("onzoom", "onzoom"), Atom("onzoom", "onzoom"),
Atom("opacity", "opacity"), Atom("opacity", "opacity"),
Atom("_operator", "operator"), Atom("_operator", "operator"),