From 68a8d951e4cf0f09c52ba6fb9959566701c45cb1 Mon Sep 17 00:00:00 2001
From: Tim Nguyen <ntim.bugs@gmail.com>
Date: Wed, 18 Sep 2019 07:40:14 +0000
Subject: [PATCH] Bug 1581973 - Set display: block; on elements relying on
 blockification behaviour. r=dao

Differential Revision: https://phabricator.services.mozilla.com/D45280

--HG--
extra : moz-landing-system : lando
---
 browser/components/preferences/in-content/findInPage.js     | 4 ++--
 browser/themes/shared/browser.inc.css                       | 2 +-
 browser/themes/shared/identity-block/identity-block.inc.css | 1 +
 browser/themes/shared/toolbarbutton-icons.inc.css           | 3 ++-
 browser/themes/shared/urlbar-autocomplete.inc.css           | 5 ++++-
 browser/themes/shared/urlbar-searchbar.inc.css              | 1 +
 6 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/browser/components/preferences/in-content/findInPage.js b/browser/components/preferences/in-content/findInPage.js
index 3929a50ad515..8287311bf289 100644
--- a/browser/components/preferences/in-content/findInPage.js
+++ b/browser/components/preferences/in-content/findInPage.js
@@ -627,8 +627,8 @@ var gSearchResultsPane = {
     if (anchorNode.tooltipNode) {
       return;
     }
-    let searchTooltip = anchorNode.ownerDocument.createXULElement("span");
-    let searchTooltipText = anchorNode.ownerDocument.createXULElement("span");
+    let searchTooltip = anchorNode.ownerDocument.createElement("span");
+    let searchTooltipText = anchorNode.ownerDocument.createElement("span");
     searchTooltip.className = "search-tooltip";
     searchTooltipText.textContent = query;
     searchTooltip.appendChild(searchTooltipText);
diff --git a/browser/themes/shared/browser.inc.css b/browser/themes/shared/browser.inc.css
index 5938b30d73bc..3b308088a2b0 100644
--- a/browser/themes/shared/browser.inc.css
+++ b/browser/themes/shared/browser.inc.css
@@ -113,7 +113,7 @@ menupopup::part(drop-indicator) {
 }
 
 #library-animatable-box[animate] {
-  display: -moz-box;
+  display: block;
 }
 
 /* Back / Forward context menu */
diff --git a/browser/themes/shared/identity-block/identity-block.inc.css b/browser/themes/shared/identity-block/identity-block.inc.css
index 23dd1b9bb29f..3c442679e834 100644
--- a/browser/themes/shared/identity-block/identity-block.inc.css
+++ b/browser/themes/shared/identity-block/identity-block.inc.css
@@ -251,6 +251,7 @@
 }
 
 #tracking-protection-icon-box > #tracking-protection-icon-animatable-box {
+  display: block;
   position: absolute;
   overflow: hidden;
   width: 16px;
diff --git a/browser/themes/shared/toolbarbutton-icons.inc.css b/browser/themes/shared/toolbarbutton-icons.inc.css
index 5133c602c188..1412411b5b68 100644
--- a/browser/themes/shared/toolbarbutton-icons.inc.css
+++ b/browser/themes/shared/toolbarbutton-icons.inc.css
@@ -20,6 +20,7 @@ toolbar[brighttext] {
 }
 
 .toolbarbutton-animatable-box {
+  display: block;
   position: absolute;
   overflow: hidden;
   z-index: 2;
@@ -59,7 +60,7 @@ toolbar[brighttext] {
   display: none;
 }
 #nav-bar-customization-target > #stop-reload-button > :-moz-any(#reload-button, #stop-button) > .toolbarbutton-animatable-box {
-  display: -moz-box;
+  display: block;
 }
 
 #stop-reload-button[animate] > #reload-button > .toolbarbutton-icon,
diff --git a/browser/themes/shared/urlbar-autocomplete.inc.css b/browser/themes/shared/urlbar-autocomplete.inc.css
index 6ae82deb50fa..fa0d4201fb66 100644
--- a/browser/themes/shared/urlbar-autocomplete.inc.css
+++ b/browser/themes/shared/urlbar-autocomplete.inc.css
@@ -70,6 +70,10 @@
   border-block: 1px solid var(--chrome-content-separator-color);
 }
 
+.urlbarView:not(.megabar):not([hidden]) {
+  display: block;
+}
+
 #urlbar-contextual-tip {
   align-items: center;
   display: flex;
@@ -421,7 +425,6 @@
   color: var(--autocomplete-popup-color);
   border-color: var(--arrowpanel-border-color);
 }
-
 #PopupSearchAutoComplete .autocomplete-richlistitem[selected] {
   background: var(--autocomplete-popup-highlight-background);
   color: var(--autocomplete-popup-highlight-color);
diff --git a/browser/themes/shared/urlbar-searchbar.inc.css b/browser/themes/shared/urlbar-searchbar.inc.css
index d9014af5fcf2..754e5b9669c0 100644
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -455,6 +455,7 @@
 }
 
 #star-button-box[animationsenabled] > #star-button[starred][animate] + #star-button-animatable-box {
+  display: block;
   position: absolute;
   overflow: hidden;
   top: calc(50% - 16.5px); /* 16.5px is half the height of the sprite */