Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1504344 - Remove the pref dom.xhr.lowercase_header.enabled; r=baku

Browse Source 
Remove the pref dom.xhr.lowercase_header.enabled, as we are unaware of any actionable compat concerns now that bug 1540688 landed, and an ESR had been spun off.

Differential Revision: https://phabricator.services.mozilla.com/D39636

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Thomas Wisniewski 2019-07-31 11:16:25 +00:00
parent 18ee326474
commit 694c55b677
4 changed files with 1 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
dom/xhr/XMLHttpRequestMainThread.cpp
View File

@ -2969,20 +2969,6 @@ bool XMLHttpRequestMainThread::IsMappedArrayBufferEnabled() {
return sIsMappedArrayBufferEnabled;
}
/* static */
bool XMLHttpRequestMainThread::IsLowercaseResponseHeader() {
static bool sLowercaseResponseHeaderAdded = false;
static bool sIsLowercaseResponseHeaderEnabled;
if (!sLowercaseResponseHeaderAdded) {
Preferences::AddBoolVarCache(&sIsLowercaseResponseHeaderEnabled,
"dom.xhr.lowercase_header.enabled", false);
sLowercaseResponseHeaderAdded = true;
}
return sIsLowercaseResponseHeaderEnabled;
}
// http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-setrequestheader
void XMLHttpRequestMainThread::SetRequestHeader(const nsACString& aName,
const nsACString& aValue,
@ -3572,14 +3558,6 @@ NS_IMPL_ISUPPORTS(XMLHttpRequestMainThread::nsHeaderVisitor,
NS_IMETHODIMP XMLHttpRequestMainThread::nsHeaderVisitor::VisitHeader(
const nsACString& header, const nsACString& value) {
if (mXHR.IsSafeHeader(header, mHttpChannel)) {
if (!IsLowercaseResponseHeader()) {
if (!mHeaderList.InsertElementSorted(HeaderEntry(header, value),
fallible)) {
return NS_ERROR_OUT_OF_MEMORY;
}
return NS_OK;
}
nsAutoCString lowerHeader(header);
ToLowerCase(lowerHeader);
if (!mHeaderList.InsertElementSorted(HeaderEntry(lowerHeader, value),

7
dom/xhr/XMLHttpRequestMainThread.h
View File

@ -304,10 +304,6 @@ class XMLHttpRequestMainThread final : public XMLHttpRequest,
// supported.
static bool IsMappedArrayBufferEnabled();
// Check pref "dom.xhr.lowercase_header.enabled" to make sure lowercased
// response header is supported.
static bool IsLowercaseResponseHeader();
void MaybeLowerChannelPriority();
public:
@ -526,9 +522,6 @@ class XMLHttpRequestMainThread final : public XMLHttpRequest,
}
bool operator<(const HeaderEntry& aOther) const {
if (!IsLowercaseResponseHeader()) {
return mName < aOther.mName;
}
uint32_t selfLen = mName.Length();
uint32_t otherLen = aOther.mName.Length();
uint32_t min = XPCOM_MIN(selfLen, otherLen);

3
modules/libpref/init/all.js
View File

@ -5453,9 +5453,6 @@ pref("toolkit.telemetry.overrideUpdateChannel", "nightly-asan");
pref("layers.mlgpu.enable-on-windows7", true);
#endif
// Enable lowercased response header name
pref("dom.xhr.lowercase_header.enabled", true);
// Control whether clients.openWindow() opens windows in the same process
// that called the API vs following our normal multi-process selection
// algorithm. Restricting openWindow to same process improves service worker

2
testing/web-platform/meta/xhr/__dir__.ini
View File

@ -1 +1 @@
prefs: [dom.xhr.lowercase_header.enabled:true, javascript.options.streams:true, dom.xhr.standard_content_type_normalization:true]
prefs: [javascript.options.streams:true, dom.xhr.standard_content_type_normalization:true]