Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 10:00:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 617523: Add better logging for failed file moves during extension installation. r=robstring, a=dtownsend

Browse Source
This commit is contained in:
Dave Townsend 2010-12-08 10:50:28 -08:00
parent ce5dd62662
commit 6951b34115
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
toolkit/mozapps/extensions/XPIProvider.jsm
View File

@ -233,10 +233,16 @@ SafeMoveOperation.prototype = {
},
_moveDirEntry: function(aDirEntry, aTargetDirectory) {
if (aDirEntry.isDirectory())
this._moveDirectory(aDirEntry, aTargetDirectory);
else
this._moveFile(aDirEntry, aTargetDirectory);
try {
if (aDirEntry.isDirectory())
this._moveDirectory(aDirEntry, aTargetDirectory);
else
this._moveFile(aDirEntry, aTargetDirectory);
}
catch (e) {
ERROR("Failure moving " + aDirEntry.path + " to " + aTargetDirectory.path);
throw e;
}
},
/**
@ -254,7 +260,6 @@ SafeMoveOperation.prototype = {
this._moveDirEntry(aFile, aTargetDirectory);
}
catch (e) {
ERROR("Failure moving " + aFile.path + " to " + aTargetDirectory.path);
this.rollback();
throw e;
}