Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 498340. Block script execution during the entire paint phase including when we call WillPaint to flush notifications. We don't want script to run and disturb (directly or indirectly) the widget hierarchy, because doing that during BeginPaint/EndPaint can confuse Windows. Other platforms might also be adversely affected. r=bz

Browse Source
This commit is contained in:
Robert O'Callahan 2009-11-10 14:00:35 +13:00
parent 10bcc5d660
commit 6b06693b5b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
view/src/nsViewManager.cpp
View File

@ -450,7 +450,6 @@ void nsViewManager::Refresh(nsView *aView, nsIRenderingContext *aContext,
}
{
nsAutoScriptBlocker scriptBlocker;
SetPainting(PR_TRUE);
nsCOMPtr<nsIRenderingContext> localcx;
@ -897,6 +896,12 @@ NS_IMETHODIMP nsViewManager::DispatchEvent(nsGUIEvent *aEvent,
{
nsPaintEvent *event = static_cast<nsPaintEvent*>(aEvent);
// We don't want script to execute anywhere in here. Since
// the widget layer has already set up a DC for painting,
// scripted changes to the widget tree (or accidental changes
// induced by script) can make painting very confused.
nsAutoScriptBlocker scriptBlocker;
if (!aView || !mContext)
break;