mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-24 13:21:05 +00:00
Bug 1548478 - Fix fluent warnings about missing translations for Bookmark Panel messages r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D30060 --HG-- extra : moz-landing-system : lando
This commit is contained in:
parent
0b10e77ba6
commit
6b25c13613
@ -38,10 +38,7 @@ class _BookmarkPanelHub {
|
||||
this._handleMessageRequest = handleMessageRequest;
|
||||
this._addImpression = addImpression;
|
||||
this._dispatch = dispatch;
|
||||
this._l10n = new DOMLocalization([
|
||||
"browser/branding/sync-brand.ftl",
|
||||
"browser/newtab/asrouter.ftl",
|
||||
]);
|
||||
this._l10n = new DOMLocalization();
|
||||
this._initialized = true;
|
||||
}
|
||||
|
||||
@ -92,6 +89,9 @@ class _BookmarkPanelHub {
|
||||
};
|
||||
|
||||
if (response && response.content) {
|
||||
// Only insert localization files if we need to show a message
|
||||
win.MozXULElement.insertFTLIfNeeded("browser/newtab/asrouter.ftl");
|
||||
win.MozXULElement.insertFTLIfNeeded("browser/branding/sync-brand.ftl");
|
||||
this.showMessage(response.content, target, win);
|
||||
this.sendImpression();
|
||||
this.sendUserEventTelemetry("IMPRESSION", win);
|
||||
@ -149,7 +149,6 @@ class _BookmarkPanelHub {
|
||||
recommendation.appendChild(title);
|
||||
recommendation.appendChild(content);
|
||||
recommendation.appendChild(cta);
|
||||
this._l10n.translateElements([...recommendation.children]);
|
||||
target.container.appendChild(recommendation);
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user