Bug 1852526 - [devtools] Remove "devtools.inspector.ruleview.inline-compatibility-warning.enabled" preference. r=devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe

Differential Revision: https://phabricator.services.mozilla.com/D187893
This commit is contained in:
Henrik Skupin 2023-09-12 08:45:44 +00:00
parent 51e2ded885
commit 6b54c871d8
8 changed files with 5 additions and 41 deletions

View File

@ -2478,8 +2478,6 @@ pref("devtools.inspector.imagePreviewTooltipSize", 300);
pref("devtools.inspector.showUserAgentStyles", false);
// Show native anonymous content and user agent shadow roots
pref("devtools.inspector.showAllAnonymousContent", false);
// Enable the inline CSS compatiblity warning in inspector rule view
pref("devtools.inspector.ruleview.inline-compatibility-warning.enabled", true);
// Enable the compatibility tool in the inspector.
pref("devtools.inspector.compatibility.enabled", true);
// Enable overflow debugging in the inspector.

View File

@ -100,10 +100,6 @@ const TEST_DATA_RENAME_RULE = [
];
add_task(async function () {
await pushPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled",
true
);
await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
const { inspector, view } = await openRuleView();

View File

@ -102,10 +102,6 @@ add_task(async function () {
"devtools.inspector.compatibility.target-browsers",
JSON.stringify(TARGET_BROWSERS)
);
await pushPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled",
true
);
await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
const { inspector, view } = await openRuleView();

View File

@ -52,10 +52,6 @@ const TEST_DATA_INITIAL = [
];
add_task(async function () {
await pushPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled",
true
);
await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
const { inspector, view } = await openRuleView();

View File

@ -119,10 +119,6 @@ const TEST_DATA_TOGGLE_INLINE = [
];
add_task(async function () {
await pushPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled",
true
);
await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
const { inspector, view } = await openRuleView();

View File

@ -37,10 +37,6 @@ const TEST_DATA = [
add_task(async function () {
startTelemetry();
await pushPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled",
true
);
await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
const { inspector, view } = await openRuleView();

View File

@ -44,11 +44,6 @@ ChromeUtils.defineESModuleGetters(lazy, {
});
const HTML_NS = "http://www.w3.org/1999/xhtml";
// @backward-compat { version 117 } The pref is enabled by default since 117.
// Let's completely remove it once 117 hits release.
const inlineCompatibilityWarningEnabled = Services.prefs.getBoolPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled"
);
const SHARED_SWATCH_CLASS = "ruleview-swatch";
const COLOR_SWATCH_CLASS = "ruleview-colorswatch";
@ -268,12 +263,10 @@ TextPropertyEditor.prototype = {
hidden: "",
});
if (inlineCompatibilityWarningEnabled) {
this.compatibilityState = createChild(this.container, "div", {
class: "ruleview-compatibility-warning",
hidden: "",
});
}
this.compatibilityState = createChild(this.container, "div", {
class: "ruleview-compatibility-warning",
hidden: "",
});
// Filter button that filters for the current property name and is
// displayed when the property is overridden by another rule.
@ -872,10 +865,7 @@ TextPropertyEditor.prototype = {
}
this.updatePropertyUsedIndicator();
if (inlineCompatibilityWarningEnabled) {
this.updatePropertyCompatibilityIndicator();
}
this.updatePropertyCompatibilityIndicator();
},
updatePropertyUsedIndicator() {

View File

@ -45,10 +45,6 @@ Browser compat warnings
CSS properties have varied level of support across different browsers. From Firefox 81, compatibility tooltips may be displayed next to any CSS properties that have known compatibility issues,as shown below.
.. note::
This feature is enabled from Firefox 81 by setting the preference ``devtools.inspector.ruleview.inline-compatibility-warning.enabled`` to ``true`` (open ``about:config`` in the URL bar to view/set Firefox preferences).
.. image:: firefox_compatibility_tootips.jpg
:alt: Tooltip displayed next to CSS element. Hover to find out browsers with compatibility issues.
:class: center