From 6b925c7d59ef18fd7050d77badec72455c1a28e9 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Wed, 26 Feb 2020 16:01:08 +0000 Subject: [PATCH] no bug - reviews doc: Add some missing groups + polish r=glob DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D64373 --HG-- extra : moz-landing-system : lando --- docs/contributing/reviews.rst | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/contributing/reviews.rst b/docs/contributing/reviews.rst index 24661bb9d99b..baf8445f92b6 100644 --- a/docs/contributing/reviews.rst +++ b/docs/contributing/reviews.rst @@ -5,7 +5,7 @@ Getting reviews Thorough code reviews are one of Mozilla's ways of ensuring code quality. Every patch must be reviewed by the module owner of the code, or one of their designated peers. -To request a review, you will need to specify a review group. If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI. +To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI. If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf. Getting attention: If a reviewer doesn't respond within a week, or so of the review request: @@ -39,6 +39,9 @@ Review groups * - #firefox-source-docs-reviewers - Documentation files and its build - `Member list `__ + * - #firefox-style-system-reviewers + - Firefox style system + - `Member list `__ * - #firefox-ux-team - User experience (UX) - `Member list `__ @@ -48,6 +51,9 @@ Review groups * - #geckoview-reviewers - Changes to GeckoView - `Member list `__ + * - #intermittent-reviewers + - Test manifest changes + - `Member list `__ * - #linter-reviewers - tools/lint/* - `Member list `__ @@ -79,5 +85,5 @@ Review groups - Changes related to WebIDL - `Member list `__ -To create a new group, fill a `new bug in Conduit::Phabricator `__. +To create a new group, fill a `new bug in Conduit::Administration `__. See `bug 1613306 `__ as example.