Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 22:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1044022 - Clean-up: IonMonkey: the LIRGenerator should inherit from MDefinitionVisitor instead of MDefinitionVisitorDefaultNYI. r=nbp

Browse Source
This commit is contained in:
Inanc Seylan 2014-08-05 07:38:00 -04:00
parent a0d0f03c2c
commit 6c280fc8c8
3 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
js/src/jit/Lowering.cpp
View File

@ -3883,3 +3883,32 @@ LIRGenerator::generate()
lirGraph_.setArgumentSlotCount(maxargslots_);
return true;
}
bool
LIRGenerator::visitPhi(MPhi *phi)
{
// Phi nodes are not lowered because they are only meaningful for the register allocator.
MOZ_ASSUME_UNREACHABLE("Unexpected Phi node during Lowering.");
}
bool
LIRGenerator::visitBeta(MBeta *beta)
{
// Beta nodes are supposed to be removed before because they are
// only used to carry the range information for Range analysis
MOZ_ASSUME_UNREACHABLE("Unexpected Beta node during Lowering.");
}
bool
LIRGenerator::visitObjectState(MObjectState *objState)
{
// ObjectState nodes are always recovered on bailouts
MOZ_ASSUME_UNREACHABLE("Unexpected ObjectState node during Lowering.");
}
bool
LIRGenerator::visitArrayState(MArrayState *objState)
{
// ArrayState nodes are always recovered on bailouts
MOZ_ASSUME_UNREACHABLE("Unexpected ArrayState node during Lowering.");
}

4
js/src/jit/Lowering.h
View File

@ -268,6 +268,10 @@ class LIRGenerator : public LIRGeneratorSpecific
bool visitSimdBinaryArith(MSimdBinaryArith *ins);
bool visitSimdValueX4(MSimdValueX4 *ins);
bool visitSimdConstant(MSimdConstant *ins);
bool visitPhi(MPhi *ins);
bool visitBeta(MBeta *ins);
bool visitObjectState(MObjectState *ins);
bool visitArrayState(MArrayState *ins);
};
} // namespace jit

2
js/src/jit/shared/Lowering-shared.h
View File

@ -23,7 +23,7 @@ class MDefinition;
class MInstruction;
class LOsiPoint;
class LIRGeneratorShared : public MDefinitionVisitorDefaultNYI
class LIRGeneratorShared : public MDefinitionVisitor
{
protected:
MIRGenerator *gen;