Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1361429 - Convert FilterButton to functional component;r=nchevobbe

Browse Source 
MozReview-Commit-ID: 5ILDOVR3GS7

--HG--
extra : rebase_source : ead2ffd56d3cf146481b0215b547b1e4abb167ed
This commit is contained in:
Brian Grinstead 2017-05-03 07:31:35 -07:00
parent 681585e2fc
commit 6c326a4688
2 changed files with 25 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
devtools/client/webconsole/new-console-output/components/filter-bar.js
View File

@ -4,7 +4,6 @@
"use strict";
const {
createFactory,
createClass,
DOM: dom,
PropTypes
@ -22,7 +21,7 @@ const { l10n } = require("devtools/client/webconsole/new-console-output/utils/me
const {
MESSAGE_LEVEL
} = require("../constants");
const FilterButton = createFactory(require("devtools/client/webconsole/new-console-output/components/filter-button"));
const FilterButton = require("devtools/client/webconsole/new-console-output/components/filter-button");
const FilterBar = createClass({

55
devtools/client/webconsole/new-console-output/components/filter-button.js
View File

@ -4,44 +4,37 @@
"use strict";
const {
createClass,
DOM: dom,
PropTypes
} = require("devtools/client/shared/vendor/react");
const actions = require("devtools/client/webconsole/new-console-output/actions/index");
const FilterButton = createClass({
FilterButton.displayName = "FilterButton";
displayName: "FilterButton",
FilterButton.propTypes = {
label: PropTypes.string.isRequired,
filterKey: PropTypes.string.isRequired,
active: PropTypes.bool.isRequired,
dispatch: PropTypes.func.isRequired,
};
propTypes: {
label: PropTypes.string.isRequired,
filterKey: PropTypes.string.isRequired,
active: PropTypes.bool.isRequired,
dispatch: PropTypes.func.isRequired,
},
onClick: function () {
this.props.dispatch(actions.filterToggle(this.props.filterKey));
},
render() {
const {active, label, filterKey} = this.props;
let classList = [
"devtools-button",
filterKey,
];
if (active) {
classList.push("checked");
}
return dom.button({
"aria-pressed": active === true,
className: classList.join(" "),
onClick: this.onClick
}, label);
function FilterButton(props) {
const {active, label, filterKey, dispatch} = props;
let classList = [
"devtools-button",
filterKey,
];
if (active) {
classList.push("checked");
}
});
return dom.button({
"aria-pressed": active === true,
className: classList.join(" "),
onClick: () => {
dispatch(actions.filterToggle(filterKey));
},
}, label);
}
module.exports = FilterButton;