Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 01:48:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 344894. Process mContentFrame before mLegendFrame in nsFieldSetFrame::BuildDisplayList, because mContentFrame might have out-of-flow frames whose placeholders are in mLegendFrame and we always need to visit out-of-flow frames before their placeholders while building display lists. r+sr=dbaron

Browse Source
This commit is contained in:
roc+%cs.cmu.edu 2006-12-10 21:53:53 +00:00
parent b235d13206
commit 6c862f2172
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
layout/forms/nsFieldSetFrame.cpp
View File

@ -228,19 +228,29 @@ nsFieldSetFrame::BuildDisplayList(nsDisplayListBuilder* aBuilder,
DO_GLOBAL_REFLOW_COUNT_DSP("nsFieldSetFrame");
}
nsDisplayListCollection contentDisplayItems;
if (mContentFrame) {
// Collect mContentFrame's display items into their own collection. We need
// to be calling BuildDisplayList on mContentFrame before mLegendFrame in
// case it contains out-of-flow frames whose placeholders are under
// mLegendFrame. However, we want mContentFrame's display items to be
// after mLegendFrame's display items in z-order, so we need to save them
// and append them later.
nsresult rv = BuildDisplayListForChild(aBuilder, mContentFrame, aDirtyRect,
contentDisplayItems);
NS_ENSURE_SUCCESS(rv, rv);
}
if (mLegendFrame) {
nsDisplayListSet set(aLists, aLists.Content());
nsresult rv = BuildDisplayListForChild(aBuilder, mLegendFrame, aDirtyRect, set);
NS_ENSURE_SUCCESS(rv, rv);
}
if (!mContentFrame)
return NS_OK;
// Allow mContentFrame's background to go onto our BorderBackground() list,
// this is OK since it won't have a real background except for event
// handling.
return BuildDisplayListForChild(aBuilder, mContentFrame, aDirtyRect, aLists);
// REVIEW: debug borders are always painted by nsFrame::BuildDisplayListForChild
// (or by the PresShell for the top level painted frame)
// Put mContentFrame's display items on the master list. Note that
// this moves mContentFrame's border/background display items to our
// BorderBackground() list, which isn't really correct, but it's OK because
// mContentFrame is anonymous and can't have its own border and background.
contentDisplayItems.MoveTo(aLists);
return NS_OK;
}
void