Bug 1895692 - turn off import/no-unassigned-import for storybook files, r=reusable-components-reviewers,frontend-codestyle-reviewers,hjones

Differential Revision: https://phabricator.services.mozilla.com/D210475

.eslintrc.js

@@ -129,6 +129,16 @@ module.exports = {
         "import/no-useless-path-segments": "error",
       },
     },
+    {
+      // Turn off no-unassigned-import for files that typically test our
+      // custom elements, which are imported for the side effects (ie
+      // the custom element being registered) rather than any particular
+      // export:
+      files: ["**/*.stories.mjs"],
+      rules: {
+        "import/no-unassigned-import": "off",
+      },
+    },
     {
       files: [
         // Bug 1773475 - For now, turn off no-unresolved on some paths where we import

browser/components/aboutlogins/content/components/input-field/input-field.stories.mjs

@@ -4,11 +4,8 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./login-password-field.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./login-username-field.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./login-origin-field.mjs";
 
 export default {

browser/components/aboutlogins/content/components/login-alert.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./login-alert.mjs";
 
 export default {

browser/components/aboutlogins/content/components/login-list-item.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./login-list-lit-item.mjs";
 
 export default {

browser/components/backup/content/backup-settings.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./backup-settings.mjs";
 
 export default {

browser/components/storybook/stories/fxview-tab-list.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "browser/components/firefoxview/fxview-tab-list.mjs";
 
 const DATE_TIME_FORMATS = {

browser/components/storybook/stories/letter-grade.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html, ifDefined } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "browser/components/shopping/content/letter-grade.mjs";
 
 export default {

browser/components/storybook/stories/login-command-button.stories.mjs

@@ -4,7 +4,6 @@
 
 import { html } from "lit.all.mjs";
 // Imported for side-effects.
-// eslint-disable-next-line import/no-unassigned-import
 import "../../aboutlogins/content/components/login-command-button.mjs";
 
 const BUTTON_TYPES = {

browser/components/storybook/stories/login-timeline.stories.mjs

@@ -4,7 +4,6 @@
 
 import { html } from "lit.all.mjs";
 // Imported for side-effects.
-// eslint-disable-next-line import/no-unassigned-import
 import "../../aboutlogins/content/components/login-timeline.mjs";
 
 export default {

browser/components/storybook/stories/migration-wizard.stories.mjs

@@ -4,14 +4,11 @@
 
 // Imported for side-effects.
 import { html } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "chrome://global/content/elements/panel-list.js";
-// eslint-disable-next-line import/no-unassigned-import
 import "browser/components/migration/content/migration-wizard.mjs";
 import { MigrationWizardConstants } from "chrome://browser/content/migration/migration-wizard-constants.mjs";
 
 // Imported for side-effects.
-// eslint-disable-next-line import/no-unassigned-import
 import "toolkit-widgets/named-deck.js";
 
 export default {

browser/components/storybook/stories/named-deck.stories.mjs

@@ -4,7 +4,6 @@
 
 import { html } from "lit.all.mjs";
 // Imported for side-effects.
-// eslint-disable-next-line import/no-unassigned-import
 import "toolkit-widgets/named-deck.js";
 
 export default {

browser/components/storybook/stories/shopping-card.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html, ifDefined } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "browser/components/shopping/content/shopping-card.mjs";
 
 export default {

browser/components/storybook/stories/shopping-container.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html, ifDefined } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "browser/components/shopping/content/shopping-container.mjs";
 // Bug 1845737: These should get imported by ShoppingMessageBar
 window.MozXULElement.insertFTLIfNeeded("browser/shopping.ftl");

browser/components/storybook/stories/shopping-message-bar.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { html, ifDefined } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "browser/components/shopping/content/shopping-message-bar.mjs";
 
 window.MozXULElement.insertFTLIfNeeded("browser/shopping.ftl");

toolkit/components/reader/color-input.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html } from "../../content/widgets/vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "chrome://global/content/reader/color-input.mjs";
 
 export default {

toolkit/components/reader/moz-slider.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html } from "../../content/widgets/vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "chrome://global/content/reader/moz-slider.mjs";
 
 export default {

toolkit/content/widgets/mach_commands.py

@@ -45,7 +45,6 @@ customElements.define("{element_name}", {class_name});
 
 STORY_HEADER = """{license}
 {html_lit_import}
-// eslint-disable-next-line import/no-unassigned-import
 {fixme_comment}import "{element_path}";
 
 export default {{

toolkit/content/widgets/moz-button/moz-button.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html, ifDefined } from "../vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./moz-button.mjs";
 
 export default {

toolkit/content/widgets/moz-card/moz-card.stories.mjs

@@ -4,7 +4,6 @@
 
 // eslint-disable-next-line import/no-unresolved
 import { classMap, html, ifDefined } from "lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./moz-card.mjs";
 
 export default {

toolkit/content/widgets/moz-five-star/moz-five-star.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html, ifDefined } from "../vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./moz-five-star.mjs";
 
 export default {

toolkit/content/widgets/moz-label/moz-label.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html, ifDefined } from "../vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./moz-label.mjs";
 
 MozXULElement.insertFTLIfNeeded("locales-preview/moz-label.storybook.ftl");

toolkit/content/widgets/moz-message-bar/moz-message-bar.stories.mjs

@@ -1,7 +1,6 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-/* eslint-disable import/no-unassigned-import */
 
 import { html, ifDefined } from "../vendor/lit.all.mjs";
 import "./moz-message-bar.mjs";

toolkit/content/widgets/moz-page-nav/moz-page-nav.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html, when } from "../vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./moz-page-nav.mjs";
 
 export default {

toolkit/content/widgets/moz-support-link/moz-support-link.stories.mjs

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { html, ifDefined } from "../vendor/lit.all.mjs";
-// eslint-disable-next-line import/no-unassigned-import
 import "./moz-support-link.mjs";
 
 MozXULElement.insertFTLIfNeeded(

toolkit/content/widgets/moz-toggle/moz-toggle.stories.mjs

@@ -1,7 +1,6 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-/* eslint-disable import/no-unassigned-import */
 
 import { html, ifDefined } from "../vendor/lit.all.mjs";
 import "./moz-toggle.mjs";

toolkit/content/widgets/panel-list/panel-list.stories.mjs

@@ -2,7 +2,6 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-// eslint-disable-next-line import/no-unassigned-import
 import "./panel-list.js";
 import { html, ifDefined } from "../vendor/lit.all.mjs";