Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1584126 - Add tests for the disconnected and display password input. r=sfoster

Browse Source 
Depends on D58130

Differential Revision: https://phabricator.services.mozilla.com/D58131

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Matthew Noorenberghe 2019-12-31 19:52:59 +00:00
parent 8f16e1275b
commit 6cb508fc32
2 changed files with 41 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
browser/components/aboutlogins/tests/browser/browser_updateLogin.js
View File

@ -56,6 +56,7 @@ add_task(async function test_login_item() {
"input[name='username']"
);
let passwordInput = loginItem._passwordInput;
let passwordDisplayInput = loginItem._passwordDisplayInput;
let editButton = loginItem.shadowRoot.querySelector(".edit-button");
@ -107,6 +108,11 @@ add_task(async function test_login_item() {
login.password,
"Password change should be reverted"
);
is(
passwordDisplayInput.value,
" ".repeat(login.password.length),
"Password change should be reverted for display"
);
ok(
!passwordInput.hasAttribute("value"),
"Password shouldn't be exposed in @value"
@ -116,6 +122,11 @@ add_task(async function test_login_item() {
login.password.length + "ch",
"Password field width shouldn't have changed"
);
is(
passwordDisplayInput.style.width,
login.password.length + "ch",
"Password field width shouldn't have changed"
);
}
await test_discard_dialog(loginList._createLoginButton);
@ -172,6 +183,11 @@ add_task(async function test_login_item() {
passwordInput.value.length + "ch",
"Password field width should be correctly updated"
);
is(
passwordDisplayInput.style.width,
passwordDisplayInput.value.length + "ch",
"Password display field width should be correctly updated"
);
editButton.click();
await ContentTaskUtils.waitForCondition(

27
browser/components/aboutlogins/tests/chrome/test_login_item.html
View File

@ -73,6 +73,9 @@ add_task(async function test_empty_item() {
is(gLoginItem.shadowRoot.querySelector("input[name='origin']").value, "", "origin should be blank");
is(gLoginItem.shadowRoot.querySelector("input[name='username']").value, "", "username should be blank");
is(gLoginItem._passwordInput.value, "", "password should be blank");
ok(!gLoginItem._passwordInput.isConnected, "Real password input should be disconnected");
is(gLoginItem._passwordDisplayInput.value, "", "password display should be blank");
ok(!isHidden(gLoginItem._passwordDisplayInput), "Password display input should be visible");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, "", "time-created should be blank when undefined");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, "", "time-changed should be blank when undefined");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-used")).args.timeUsed, "", "time-used should be blank when undefined");
@ -89,9 +92,15 @@ add_task(async function test_set_login() {
let usernameInput = gLoginItem.shadowRoot.querySelector("input[name='username']");
is(usernameInput.value, TEST_LOGIN_1.username, "username should be populated");
is(document.l10n.getAttributes(usernameInput).id, "about-logins-login-item-username", "username field should have default placeholder when not editing");
let passwordInput = gLoginItem._passwordInput;
is(passwordInput.value, TEST_LOGIN_1.password, "password should be populated");
ok(!passwordInput.hasAttribute("value"), "Password shouldn't be exposed in @value");
ok(!gLoginItem._passwordInput.isConnected, "Real password input should be disconnected");
let passwordDisplayInput = gLoginItem._passwordDisplayInput;
is(passwordDisplayInput.value, " ".repeat(TEST_LOGIN_1.password.length), "password display should be populated");
ok(!isHidden(passwordDisplayInput), "Password display input should be visible");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, TEST_LOGIN_1.timeCreated, "time-created should be populated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, TEST_LOGIN_1.timePasswordChanged, "time-changed should be populated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-used")).args.timeUsed, TEST_LOGIN_1.timeLastUsed, "time-used should be populated");
@ -179,6 +188,7 @@ add_task(async function test_edit_login() {
);
is(usernameInput.placeholder, "", "there should be no placeholder on the username input in edit mode");
is(gLoginItem._passwordInput.value, TEST_LOGIN_1.password, "password should be populated");
is(gLoginItem._passwordDisplayInput.value, " ".repeat(TEST_LOGIN_1.password.length), "password display should be populated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, TEST_LOGIN_1.timeCreated, "time-created should be populated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, TEST_LOGIN_1.timePasswordChanged, "time-changed should be populated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-used")).args.timeUsed, TEST_LOGIN_1.timeLastUsed, "time-used should be populated");
@ -233,19 +243,23 @@ add_task(async function test_reveal_password_change_selected_login() {
await SimpleTest.promiseWaitForCondition(() => passwordInput.type == "text",
"waiting for password input type to change after checking for master password");
is(passwordInput.type, "text", "Password should be unmasked when checkbox is clicked");
ok(!isHidden(passwordInput), "Password input should be visible");
let editButton = gLoginItem.shadowRoot.querySelector(".edit-button");
editButton.click();
await asyncElementRendered();
ok(!isHidden(passwordInput), "Password input should still be visible");
ok(revealCheckbox.checked, "reveal-checkbox should remain checked when entering 'edit' mode");
gLoginItem.shadowRoot.querySelector(".cancel-button").click();
ok(!revealCheckbox.checked, "reveal-checkbox should be unchecked after canceling 'edit' mode");
revealCheckbox.click();
ok(isHidden(passwordInput), "Password input should be hidden");
ok(!isHidden(gLoginItem._passwordDisplayInput), "Password display should be visible");
gLoginItem.setLogin(TEST_LOGIN_2);
ok(!revealCheckbox.checked, "reveal-checkbox should be unchecked when changing logins");
is(passwordInput.type, "password", "Password should be masked by default when switching logins");
ok(isHidden(passwordInput), "Password input should be hidden");
ok(!isHidden(gLoginItem._passwordDisplayInput), "Password display should be visible");
});
add_task(async function test_set_login_empty() {
@ -260,6 +274,8 @@ add_task(async function test_set_login_empty() {
is(gLoginItem.shadowRoot.querySelector("input[name='origin']").value, "", "origin should be empty");
is(gLoginItem.shadowRoot.querySelector("input[name='username']").value, "", "username should be empty");
is(gLoginItem._passwordInput.value, "", "password should be empty");
ok(!isHidden(gLoginItem._passwordInput), "Real password input should be visible in edit mode");
ok(isHidden(gLoginItem._passwordDisplayInput), "Password display should be hidden in edit mode");
ok(!gLoginItem._passwordInput.hasAttribute("value"), "Password shouldn't be exposed in @value");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, "", "time-created should be blank when undefined");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, "", "time-changed should be blank when undefined");
@ -317,6 +333,9 @@ add_task(async function test_different_login_modified() {
is(gLoginItem.shadowRoot.querySelector("input[name='username']").value, TEST_LOGIN_1.username, "username should be unchanged");
is(gLoginItem._passwordInput.value, TEST_LOGIN_1.password, "password should be unchanged");
ok(!gLoginItem._passwordInput.hasAttribute("value"), "Password shouldn't be exposed in @value");
ok(!gLoginItem._passwordInput.isConnected, "Real password input should be disconnected in masked non-edit mode");
ok(!isHidden(gLoginItem._passwordDisplayInput), "Password display should be visible in masked non-edit mode");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, TEST_LOGIN_1.timeCreated, "time-created should be unchanged");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, TEST_LOGIN_1.timePasswordChanged, "time-changed should be unchanged");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-used")).args.timeUsed, TEST_LOGIN_1.timeLastUsed, "time-used should be unchanged");
@ -332,6 +351,8 @@ add_task(async function test_different_login_removed() {
is(gLoginItem.shadowRoot.querySelector("input[name='username']").value, TEST_LOGIN_1.username, "username should be unchanged");
is(gLoginItem._passwordInput.value, TEST_LOGIN_1.password, "password should be unchanged");
ok(!gLoginItem._passwordInput.hasAttribute("value"), "Password shouldn't be exposed in @value");
ok(!gLoginItem._passwordInput.isConnected, "Real password input should be disconnected in masked non-edit mode");
ok(!isHidden(gLoginItem._passwordDisplayInput), "Password display should be visible in masked non-edit mode");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, TEST_LOGIN_1.timeCreated, "time-created should be unchanged");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, TEST_LOGIN_1.timePasswordChanged, "time-changed should be unchanged");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-used")).args.timeUsed, TEST_LOGIN_1.timeLastUsed, "time-used should be unchanged");
@ -347,6 +368,8 @@ add_task(async function test_login_modified() {
is(gLoginItem.shadowRoot.querySelector("input[name='username']").value, modifiedLogin.username, "username should be updated");
is(gLoginItem._passwordInput.value, modifiedLogin.password, "password should be updated");
ok(!gLoginItem._passwordInput.hasAttribute("value"), "Password shouldn't be exposed in @value");
ok(!gLoginItem._passwordInput.isConnected, "Real password input should be disconnected in masked non-edit mode");
ok(!isHidden(gLoginItem._passwordDisplayInput), "Password display should be visible in masked non-edit mode");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-created")).args.timeCreated, modifiedLogin.timeCreated, "time-created should be updated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-changed")).args.timeChanged, modifiedLogin.timePasswordChanged, "time-changed should be updated");
is(document.l10n.getAttributes(gLoginItem.shadowRoot.querySelector(".time-used")).args.timeUsed, modifiedLogin.timeLastUsed, "time-used should be updated");