Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1847901 - Should not show fullscreen warning if the user has disabled it explicitly; r=Gijs

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D185977
This commit is contained in:
Edgar Chen 2023-08-14 15:52:24 +00:00
parent 537380474e
commit 6cd338149e
2 changed files with 58 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
browser/base/content/browser-fullScreenAndPointerLock.js
View File

@ -64,8 +64,12 @@ var PointerlockFsWarning = {
this._element.addEventListener("transitionend", this);
this._element.addEventListener("transitioncancel", this);
window.addEventListener("mousemove", this, true);
window.addEventListener("activate", this);
window.addEventListener("deactivate", this);
// If the user explicitly disables the prompt, there's no need to detect
// activation.
if (timeout > 0) {
window.addEventListener("activate", this);
window.addEventListener("deactivate", this);
}
// The timeout to hide the warning box after a while.
this._timeoutHide = new this.Timeout(() => {
window.removeEventListener("activate", this);

52
browser/base/content/test/fullscreen/browser_fullscreen_warning.js
View File

@ -226,3 +226,55 @@ add_task(async function test_fullscreen_reappear() {
await document.exitFullscreen();
});
});
// https://bugzilla.mozilla.org/show_bug.cgi?id=1847901
add_task(async function test_fullscreen_warning_disabled() {
// Disable fullscreen warning
await SpecialPowers.pushPrefEnv({
set: [["full-screen-api.warning.timeout", 0]],
});
await BrowserTestUtils.withNewTab("https://example.com", async browser => {
let newWin = await BrowserTestUtils.openNewBrowserWindow();
let fsWarning = document.getElementById("fullscreen-warning");
let mut = new MutationObserver(mutations => {
ok(false, `${mutations[0].attributeName} attribute should not change`);
});
mut.observe(fsWarning, {
attributeFilter: ["hidden", "onscreen", "ontop"],
});
info("Entering full screen.");
await SimpleTest.promiseFocus(window);
await SpecialPowers.spawn(browser, [], async () => {
return content.document.body.requestFullscreen();
});
// Wait a bit to ensure no state change.
await new Promise(resolve => {
requestAnimationFrame(() => {
requestAnimationFrame(resolve);
});
});
info("The fullscreen warning should still not show after switching focus.");
await SimpleTest.promiseFocus(newWin);
await SimpleTest.promiseFocus(window);
// Wait a bit to ensure no state change.
await new Promise(resolve => {
requestAnimationFrame(() => {
requestAnimationFrame(resolve);
});
});
mut.disconnect();
info("Close new browser window.");
await BrowserTestUtils.closeWindow(newWin);
info("Exit fullscreen.");
await document.exitFullscreen();
});
// Revert the setting to avoid affecting subsequent tests.
await SpecialPowers.popPrefEnv();
});