Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 16:22:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1715209 - [geckodriver] Fix handling of implicit session delete return value. r=webdriver-reviewers,whimboo

Browse Source 
The arguments to map_or_else were the wrong way around. Since it's easier to read in this case
switch over to an explicit match statement.

Differential Revision: https://phabricator.services.mozilla.com/D117155
This commit is contained in:
James Graham 2021-06-08 19:26:50 +00:00
parent 9083983080
commit 6d2acef1e8
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
testing/webdriver/src/server.rs
View File

@ -133,12 +133,10 @@ impl<T: WebDriverHandler<U>, U: WebDriverExtensionRoute> Dispatcher<T, U> {
),
command: WebDriverCommand::DeleteSession,
};
self.handler
.handle_command(&self.session, delete_session)
.map_or_else(
|_| SessionTeardownKind::Deleted,
|_| SessionTeardownKind::NotDeleted,
)
match self.handler.handle_command(&self.session, delete_session) {
Ok(_) => SessionTeardownKind::Deleted,
Err(_) => SessionTeardownKind::NotDeleted,
}
}
_ => kind,
};