Make static some nsCSSDeclaration methods that don't need their this. b=336322 r+sr=bzbarsky

This commit is contained in:
dbaron%dbaron.org 2006-05-02 23:36:17 +00:00
parent c448ba0ec4
commit 6d979fef96
3 changed files with 16 additions and 5 deletions

View File

@ -280,7 +280,10 @@ PRBool nsCSSDeclaration::AppendValueToString(nsCSSProperty aProperty, nsAString&
return storage != nsnull;
}
PRBool nsCSSDeclaration::AppendCSSValueToString(nsCSSProperty aProperty, const nsCSSValue& aValue, nsAString& aResult) const
/* static */ PRBool
nsCSSDeclaration::AppendCSSValueToString(nsCSSProperty aProperty,
const nsCSSValue& aValue,
nsAString& aResult)
{
nsCSSUnit unit = aValue.GetUnit();
@ -730,8 +733,9 @@ nsCSSDeclaration::AllPropertiesSameValue(PRInt32 aFirst, PRInt32 aSecond,
return PR_TRUE;
}
void
nsCSSDeclaration::AppendImportanceToString(PRBool aIsImportant, nsAString& aString) const
/* static */ void
nsCSSDeclaration::AppendImportanceToString(PRBool aIsImportant,
nsAString& aString)
{
if (aIsImportant) {
aString.AppendLiteral(" ! important");

View File

@ -153,11 +153,13 @@ private:
nsCSSDeclaration& operator=(const nsCSSDeclaration& aCopy);
PRBool operator==(const nsCSSDeclaration& aCopy) const;
void AppendImportanceToString(PRBool aIsImportant, nsAString& aString) const;
static void AppendImportanceToString(PRBool aIsImportant, nsAString& aString);
// return whether there was a value in |aValue| (i.e., it had a non-null unit)
PRBool AppendValueToString(nsCSSProperty aProperty, nsAString& aResult) const;
// return whether there was a value in |aValue| (i.e., it had a non-null unit)
PRBool AppendCSSValueToString(nsCSSProperty aProperty, const nsCSSValue& aValue, nsAString& aResult) const;
static PRBool AppendCSSValueToString(nsCSSProperty aProperty,
const nsCSSValue& aValue,
nsAString& aResult);
// May be called only for properties whose type is eCSSType_Value.
nsresult GetValueOrImportantValue(nsCSSProperty aProperty, nsCSSValue& aValue) const;

View File

@ -282,6 +282,11 @@ public:
const; // Not really const, but pretending
#ifdef DEBUG
// XXX This is buggy and should have its contents replaced with
// nsCSSDeclaration::AppendCSSValueToString (and the optional
// parameter dropped). (Probably easier to do after making
// nsCSSStruct List methods be table-driven, since this function
// appends more than just the value.)
NS_HIDDEN_(void)
AppendToString(nsAString& aBuffer,
nsCSSProperty aPropID = eCSSProperty_UNKNOWN) const;