Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1565515 - Added TODO comments on duplicated code r=asuth,ttung

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D37852

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Simon Giesecke 2019-07-26 13:45:47 +00:00
parent 6dac2d86ea
commit 6e402be069
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/indexedDB/test/helpers.js
View File

@ -485,6 +485,8 @@ function workerScript() {
}, },
}; };
// TODO this is duplicate from the global compareKeys function defined above,
// this duplication should be avoided (bug 1565986)
self.compareKeys = function(_k1_, _k2_) { self.compareKeys = function(_k1_, _k2_) {
let t = typeof _k1_; let t = typeof _k1_;
if (t != typeof _k2_) { if (t != typeof _k2_) {

3
dom/indexedDB/test/unit/xpcshell-head-parent-process.js
View File

@ -150,6 +150,9 @@ function continueToNextStepSync() {
testGenerator.next(); testGenerator.next();
} }
// TODO compareKeys is duplicated in ../helpers.js, can we import that here?
// the same applies to many other functions in this file
// this duplication should be avoided (bug 1565986)
function compareKeys(k1, k2) { function compareKeys(k1, k2) {
let t = typeof k1; let t = typeof k1;
if (t != typeof k2) { if (t != typeof k2) {